Date: Mon, 02 Aug 2004 19:55:37 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: njl@FreeBSD.org Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/eisa eisaconf.c Message-ID: <20040802.195537.104022299.imp@bsdimp.com> In-Reply-To: <200408030041.i730fl2S048673@repoman.freebsd.org> References: <200408030041.i730fl2S048673@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <200408030041.i730fl2S048673@repoman.freebsd.org>
Nate Lawson <njl@FreeBSD.org> writes:
: njl 2004-08-03 00:41:47 UTC
:
: FreeBSD src repository
:
: Modified files:
: sys/dev/eisa eisaconf.c
: Log:
: Change EISA probing to be less invasive. Instead of probing all slots
: unconditionally, stop after the first one (system board) if no EISA hardware
: is detected. This fixes a boot hang (i.e. Thinkpad) when ACPI is disabled.
: Also, split the probe code into a separate function and do some style cleanup.
:
: Note that the Adaptec 2842 VLB controller probe is broken by this change
: and will fail to probe. It should be fixed separately.
This change, btw, was reviewed by gibbs and imp prior to the
commit... The 2842 VLB controller is about 13 years old. There will
likely be a fix for it soon from the ahc maintainer. However, even if
there isn't, the belief is that modern laptop owners with the eisa
hang problem is >> the 2842 controller. I believe the re@ signed off
on this as well.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040802.195537.104022299.imp>