Date: Tue, 21 Oct 2008 09:30:42 +0000 (UTC) From: Robert Watson <rwatson@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-7@freebsd.org Subject: svn commit: r184116 - in stable/7/sys: . fs/portalfs Message-ID: <200810210930.m9L9UgbH094408@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: rwatson Date: Tue Oct 21 09:30:42 2008 New Revision: 184116 URL: http://svn.freebsd.org/changeset/base/184116 Log: Merge r183806 from head to stable/7: The locking in portalfs's socket connect code is no less correct than identical code in connect(2), so remove XXX that it might be incorrect. Approved by: re (kib) Modified: stable/7/sys/ (props changed) stable/7/sys/fs/portalfs/portal_vnops.c Modified: stable/7/sys/fs/portalfs/portal_vnops.c ============================================================================== --- stable/7/sys/fs/portalfs/portal_vnops.c Tue Oct 21 08:03:12 2008 (r184115) +++ stable/7/sys/fs/portalfs/portal_vnops.c Tue Oct 21 09:30:42 2008 (r184116) @@ -280,7 +280,6 @@ portal_open(ap) * will happen if the server dies. Sleep for 5 second intervals * and keep polling the reference count. XXX. */ - /* XXXRW: Locking? */ SOCK_LOCK(so); while ((so->so_state & SS_ISCONNECTING) && so->so_error == 0) { if (fmp->pm_server->f_count == 1) {
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200810210930.m9L9UgbH094408>