Date: Fri, 5 Feb 2016 01:14:03 +0000 From: "sepherosa_gmail.com (Sepherosa Ziehau)" <phabric-noreply@FreeBSD.org> To: freebsd-net@freebsd.org Subject: [Differential] [Commented On] D5185: tcp/lro: Allow network drivers to set the limit for TCP ACK/data segment aggregation limit Message-ID: <47c267ddddb7d0405fff0ce47250d91a@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-wthfupxgtart42sdknmd-req@FreeBSD.org> References: <differential-rev-PHID-DREV-wthfupxgtart42sdknmd-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
sepherosa_gmail.com added a comment. I will adjust the patch accordingly. INLINE COMMENTS sys/netinet/tcp_lro.c:655 Sure :) sys/netinet/tcp_lro.c:684 Sounds fine to me. I did the byte limit before (https://reviews.freebsd.org/D4825). But it turns out the ACKs need seperate limit (append count based). To make them consistent, I changed the original patch to use append count too. REVISION DETAIL https://reviews.freebsd.org/D5185 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: sepherosa_gmail.com, network, adrian, delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com, hselasky, np, transport, gallatin Cc: freebsd-virtualization-list, freebsd-net-list
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?47c267ddddb7d0405fff0ce47250d91a>