Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 4 Apr 2017 07:24:34 -0500
From:      Kyle Evans <kevans91@ksu.edu>
To:        Andrey Chernov <ache@freebsd.org>
Cc:        Ed Maste <emaste@freebsd.org>, <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r316477 - head/usr.bin/grep
Message-ID:  <CACNAnaGMv0WGO0MjnJwrYTdZhutoU7qPbzkiCS2zi2wnCKV=ZQ@mail.gmail.com>
In-Reply-To: <4ceb1a18-3a72-c0e3-b2e2-f71d687cd153@freebsd.org>
References:  <201704032316.v33NGpbo037305@repo.freebsd.org> <4ceb1a18-3a72-c0e3-b2e2-f71d687cd153@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Apr 4, 2017 at 7:07 AM, Andrey Chernov <ache@freebsd.org> wrote:

> On 04.04.2017 2:16, Ed Maste wrote:
> >                       if (color)
> > -                             fprintf(stdout, "\33[m\33[K");
> > +                             fprintf(stdout, "\33[00m\33[K");
>
> Please back that one out. We don't need to handle internally or print
> remotely excessive 00.
> At least according to
> https://en.wikipedia.org/wiki/ANSI_escape_code
> "With no parameters, CSI m is treated as CSI 0 m (reset / normal), which
> is typical of most of the ANSI escape sequences."


Hi ache@,

This specific change was made in the name of explicitly matching colored
output of GNU grep for simplification of regression test purposes, rather
than for good form. Is it still unacceptable to do so?

Thanks,

Kyle Evans



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaGMv0WGO0MjnJwrYTdZhutoU7qPbzkiCS2zi2wnCKV=ZQ>