Date: Mon, 13 Apr 2009 10:48:16 -0400 From: John Baldwin <jhb@freebsd.org> To: Ed Schouten <ed@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r190919 - in head/sys: amd64/amd64 amd64/include i386/i386 i386/include Message-ID: <200904131048.16545.jhb@freebsd.org> In-Reply-To: <200904111401.n3BE1108088009@svn.freebsd.org> References: <200904111401.n3BE1108088009@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday 11 April 2009 10:01:01 am Ed Schouten wrote: > Author: ed > Date: Sat Apr 11 14:01:01 2009 > New Revision: 190919 > URL: http://svn.freebsd.org/changeset/base/190919 > > Log: > Simplify in/out functions (for i386 and AMD64). > > Remove a hack to generate more efficient code for port numbers below > 0x100, which has been obsolete for at least ten years, because GCC has > an asm constraint to specify that. > > Submitted by: Christoph Mallon <christoph mallon gmx de> Hmm, it appears that you broke the DDB usage: db> call inb(0x20) Since the functions are now called 'inb_' and 'outb_'. Perhaps the inline routines should be _inb() and _outb() and inb and outb should still be macros that wrap them that then get undefined in machdep.c for the functions used in DDB? -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200904131048.16545.jhb>