Date: Sun, 3 Jan 2010 14:15:10 +0000 From: Rui Paulo <rpaulo@freebsd.org> To: Yohanes Nugroho <yohanes@gmail.com> Cc: freebsd-arm@freebsd.org Subject: Re: CNS11XX FreeBSD port completed Message-ID: <4DC598C4-2CB4-4D98-8101-3CA7B3985BE9@freebsd.org> In-Reply-To: <260bb65e1001030033s9782689xedfd54520c62b01d@mail.gmail.com> References: <260bb65e0912110627o6b67b399vabaae57477b91023@mail.gmail.com> <260bb65e0912250948w6f714367w672a1ebf037fb7f7@mail.gmail.com> <BEE46B4D-5280-48DF-B2FD-36D1FEFA332A@freebsd.org> <260bb65e1001030033s9782689xedfd54520c62b01d@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
On 3 Jan 2010, at 08:33, Yohanes Nugroho wrote: > On Tue, Dec 29, 2009 at 8:53 PM, Rui Paulo <rpaulo@freebsd.org> wrote: > > Hi Rui, > > Thank you for spending some time to read my code. Here is the new patch. > >> Some comments: >> * please read style(9) and try to follow these guidelines on your code > > ok, I just found out about this (I should have read this earlier). > >> >> * did you forget to add a kernel config file for this board? > > it is in sys/arm/conf/CNS11XXNAS Did you forget to svn add the file? I can't see sys/arm/conf/CNS11XXNAS in the diff. -- Rui Paulohelp
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4DC598C4-2CB4-4D98-8101-3CA7B3985BE9>