Date: Thu, 5 Feb 1998 23:55:44 +0300 From: =?koi8-r?B?4c7E0sXKIP7F0s7P1w==?= <ache@nagual.pp.ru> To: Martin Cracauer <cracauer@cons.org>, cvs-commiters@FreeBSD.ORG Subject: Re: Please review fix for /bin/sh SIGQUIT/SIGINT problem Message-ID: <19980205235544.65532@nagual.pp.ru> In-Reply-To: <19980205213833.25257@cons.org>; from cracauer@cons.org on Thu, Feb 05, 1998 at 09:38:33PM %2B0100 References: <19980205202824.51394@cons.org> <19980205204320.31887@cons.org> <19980205213833.25257@cons.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Feb 05, 1998 at 09:38:33PM +0100, Martin Cracauer wrote:
> + if (mode == FORK_FG) {
> + oldsigquit = signal(SIGQUIT,SIG_IGN);
> + oldsigint = signal(SIGINT,SIG_IGN);
> + oldsigs_valid = 1;
> + }
> pid = fork();
> if (pid == -1) {
> TRACE(("Fork failed, errno=%d\n", errno));
> ***************
I not see you restore signals immediately after failed fork.
BTW, it seems "return pid" must be added for pid == -1 case
--
Andrey A. Chernov
<ache@nietzsche.net>
http://www.nagual.pp.ru/~ache/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19980205235544.65532>