Date: Tue, 8 Oct 2002 10:55:49 -0600 From: "Kenneth D. Merry" <ken@kdm.org> To: "Moore, Eric Dean" <emoore@lsil.com> Cc: freebsd-scsi@FreeBSD.ORG Subject: Re: CAM:READ-12 and WRITE-12 support Message-ID: <20021008105549.A34847@panzer.kdm.org> In-Reply-To: <0E3FA95632D6D047BA649F95DAB60E5701528EF0@EXA-ATLANTA.se.lsil.com>; from emoore@lsil.com on Tue, Oct 08, 2002 at 12:20:29PM -0400 References: <0E3FA95632D6D047BA649F95DAB60E5701528EF0@EXA-ATLANTA.se.lsil.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Oct 08, 2002 at 12:20:29 -0400, Moore, Eric Dean wrote:
> I'm concerned about 12 byte cdbs support in scsi_read_write() [source
> /sys/cam/scsi/scsi_all.c].
> For 12 byte cdb's the block_count is being set in
> scsi_ulto4b(block_count,scsi_cmd->length);
> I think there might be a problem with the location of the length member in
> structure scsi_rw_12.
>
> from [sys/cam/scsi/scsi-all.h]
>
> struct scsi_rw_12
> {
> u_int8_t opcode;
> u_int8_t byte2;
> u_int8_t addr[4];
> u_int8_t reserved;
> u_int8_t length[4];
> u_int8_t control;
> };
>
> According to SCSI-2 spec it should be
>
> struct scsi_rw_12
> {
> u_int8_t opcode;
> u_int8_t byte2;
> u_int8_t addr[4];
> u_int8_t length[4];
> u_int8_t reserved;
> u_int8_t control;
> };
>
>
> * should the reserved field should be in bytes 7-10, instead of byte 8-11.
Oops, you're right.
Thanks for pointing that out!
I'll fix it...
Ken
--
Kenneth Merry
ken@kdm.org
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-scsi" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021008105549.A34847>