Date: Fri, 3 Apr 1998 21:48:36 +0400 From: =?koi8-r?B?4c7E0sXKIP7F0s7P1w==?= <ache@nagual.pp.ru> To: Poul-Henning Kamp <phk@critter.freebsd.dk> Cc: "Alok K. Dhir" <adhir@worldbank.org>, current@FreeBSD.ORG, adkin003@tc.umn.edu Subject: Re: More info RE: X slowdown in -current Message-ID: <19980403214836.43861@nagual.pp.ru> In-Reply-To: <2732.891625044@critter.freebsd.dk>; from phk@critter.freebsd.dk on Fri, Apr 03, 1998 at 07:37:24PM %2B0200 References: <19980403211212.09449@nagual.pp.ru> <2732.891625044@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Apr 03, 1998 at 07:37:24PM +0200, Poul-Henning Kamp wrote: > In message <19980403211212.09449@nagual.pp.ru>, =?koi8-r?B?4c7E0sXKIP7F0s7P1w== > ?= writes: > >On Fri, Apr 03, 1998 at 07:08:12PM +0200, Poul-Henning Kamp wrote: > >> In message <Pine.BSF.3.96.980403114954.338A-100000@shadow.worldbank.org>, " > >Alok > >> K. Dhir" writes: > >> > > >> >This patch worked great. Is there any reason why it shouldn't be > >> >committed? > >> > >> Yes there is a reason: it is wrong, it lacks a splhigh(). > >> > >> Please report on the version currently in -current. > > > > > >This report/patch already *IS* for very latest version currently in > >-current, your fix really fix nothing, the bug remains. > > Are you sure you are looking at 1.35 ? Yes. > If you compare version 1.33 and 1.35 you will see that there is no > change in spl() placement and protection. I simply fail to see > what the heck you think you need to fuck with splhigh for... > > Try to diff 1.33 and 1.35 and see what I mean... With splhigh() any version cause great slowness. The knob is not various calculation styles but splhigh() itself. I suppose that splihigh() was there for a long time, it means that proposed patch is workaround only and real bug is somewhere else. In any case it manifestates itself very recently after your general time changes. Why you not simple run X11/Netscape to see the bug in action? It is very visible. -- Andrey A. Chernov http://www.nagual.pp.ru/~ache/ MTH/SH/HE S-- W-- N+ PEC>+ D A a++ C G>+ QH+(++) 666+>++ Y To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19980403214836.43861>