Date: Sat, 17 Aug 2024 10:41:38 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 269770] libalias udp redirect_port temporary translation failure Message-ID: <bug-269770-227-Si6oXIl28N@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-269770-227@https.bugs.freebsd.org/bugzilla/>
index | next in thread | previous in thread | raw e-mail
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269770 --- Comment #8 from Peter Much <pmc@citylink.dinoex.sub.org> --- Created attachment 252840 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=252840&action=edit workaround/fix In libalias/alias_db.c:_FindLinkIn() is a search for a temporary (fully specified) flow, and on success it does return (UseLink(la, lnk)); Further down in this function is another search for a permanent (partially specified) portforward. If we return through UseLink(), this then does CleanupLink(la, &lnk, 0) and there is a check for expiry, and then DeleteLink(lnk, ...) So from there, if the link is expired, we get a NULL back, and the permanent portforward is not searched for. I fix this by delaying the CleanupLink() invocation to after the permanent link has been searched for. And since this would add another search on potentially every packet, I delay it only if the temporary link has expired. -- You are receiving this mail because: You are the assignee for the bug.home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-269770-227-Si6oXIl28N>