Date: Sun, 09 Dec 2012 19:42:02 +0100 From: Florian Smeets <flo@smeets.im> To: Mateusz Guzik <mjguzik@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Andre Oppermann <andre@FreeBSD.org> Subject: Re: svn commit: r243147 - head/usr.bin/fetch Message-ID: <50C4DB7A.9050302@smeets.im> In-Reply-To: <20121209182730.GA28989@dft-labs.eu> References: <201211161205.qAGC5Bwr081144@svn.freebsd.org> <50C4D31E.4080000@smeets.im> <20121209182730.GA28989@dft-labs.eu>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 09.12.12 19:27, Mateusz Guzik wrote: > On Sun, Dec 09, 2012 at 07:06:22PM +0100, Florian Smeets wrote: >> On 16.11.12 13:05, Andre Oppermann wrote: >>> Author: andre >>> Date: Fri Nov 16 12:05:10 2012 >>> New Revision: 243147 >>> URL: http://svnweb.freebsd.org/changeset/base/243147 >>> >>> Log: >>> Change fetch(1) to: >>> >>> o Report the instantaneous bandwidth instead of an average since the >>> beginning of the download. >>> >>> o At the finish of the download report the average bandwidth and also >>> the total time it took instead of 00m00s. >>> >> >> Andre, >> >> it looks like this change breaks the bandwidth calculation when using -r >> >> 52% of 146 MB -25199509 Bps 03m28s >> >> Going back to r243146 fixes it. >> > > Try this: > diff --git a/usr.bin/fetch/fetch.c b/usr.bin/fetch/fetch.c > index 025fcdc..e723d40 100644 > --- a/usr.bin/fetch/fetch.c > +++ b/usr.bin/fetch/fetch.c > @@ -243,7 +243,7 @@ stat_start(struct xferstat *xs, const char *name, off_t size, off_t of > gettimeofday(&xs->start, NULL); > xs->last.tv_sec = xs->last.tv_usec = 0; > xs->size = size; > - xs->offset = offset; > + xs->offset = 0; > xs->rcvd = offset; > xs->lastrcvd = offset; > if (v_tty && v_level > 0) > That way the bandwidth calculation looks OK but now it counts the time since starting to resume the download and not the time left :) 63% of 146 MB 7069 kBps 00m07s Florian [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iEYEARECAAYFAlDE23oACgkQapo8P8lCvwnVaQCdHhGGQsFzDMcqve+kVqsGsFEJ 4OkAoJUIEMjAovUsgNbos0ASjrAXmbO/ =2JJ9 -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50C4DB7A.9050302>