Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 19 Nov 2024 10:15:13 -0500
From:      John Baldwin <jhb@FreeBSD.org>
To:        Michal Meloun <mmel@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   Re: git: b882d21558f3 - main - arm: link all .rodata variants into one output section
Message-ID:  <0e6393a7-0624-4a24-8537-60917728ae8a@FreeBSD.org>
In-Reply-To: <202411171136.4AHBaK2D056199@gitrepo.freebsd.org>
References:  <202411171136.4AHBaK2D056199@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 11/17/24 03:36, Michal Meloun wrote:
> The branch main has been updated by mmel:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=b882d21558f37e6a565694ac9b8f2a519e5b86fa
> 
> commit b882d21558f37e6a565694ac9b8f2a519e5b86fa
> Author:     Michal Meloun <mmel@FreeBSD.org>
> AuthorDate: 2024-11-17 11:28:47 +0000
> Commit:     Michal Meloun <mmel@FreeBSD.org>
> CommitDate: 2024-11-17 11:35:55 +0000
> 
>      arm: link all .rodata variants into one output section
>      
>      MFC after:      1 week
> ---
>   sys/conf/ldscript.arm | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sys/conf/ldscript.arm b/sys/conf/ldscript.arm
> index d9edcfac9f78..7cf904ce39ff 100644
> --- a/sys/conf/ldscript.arm
> +++ b/sys/conf/ldscript.arm
> @@ -17,7 +17,7 @@ SECTIONS
>     _etext = .;
>     PROVIDE (etext = .);
>     .fini      : { *(.fini)    } =0x9090
> -  .rodata    : { *(.rodata) *(.gnu.linkonce.r*) }
> +  .rodata    : { *(.rodata*) *(.gnu.linkonce.r*) }
>     .rodata1   : { *(.rodata1) }

Is this line now spurious or do linker scripts prefer more exact matches?

>      .interp     : { *(.interp) 	}
>     .hash          : { *(.hash)		}

-- 
John Baldwin




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0e6393a7-0624-4a24-8537-60917728ae8a>