Date: Mon, 18 Sep 2017 08:09:46 -0700 From: Conrad Meyer <cem@freebsd.org> To: Hans Petter Selasky <hps@selasky.org> Cc: Conrad Meyer <cem@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r323692 - in head/sys/compat: linsysfs linux Message-ID: <CAG6CVpVuhfGgROVhVuYU=sfN-XokBQ4qVLRGqt=2CMn3MketrA@mail.gmail.com> In-Reply-To: <dab227ed-2be6-3120-8089-51362340bc14@selasky.org> References: <201709172340.v8HNeGuP016998@repo.freebsd.org> <dab227ed-2be6-3120-8089-51362340bc14@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Seems unhelpful here, as the maximum length of "226:%d" is shorter than the buffer. On Mon, Sep 18, 2017 at 3:38 AM, Hans Petter Selasky <hps@selasky.org> wrote: > On 09/18/17 01:40, Conrad Meyer wrote: >> >> + sprintf(chardevname, "226:%d", >> + device_get_unit(dev)); > > > Hi, > > Try to use snprintf(). Define the chardevname size as a macro, or just > allocate it on the stack if it is < 32 bytes. > > --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpVuhfGgROVhVuYU=sfN-XokBQ4qVLRGqt=2CMn3MketrA>