Date: Fri, 8 Mar 2019 19:21:51 +0000 From: Brooks Davis <brooks@freebsd.org> To: Jan Beich <jbeich@FreeBSD.org> Cc: Adam Weinberger <adamw@adamw.org>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r495007 - in head/devel: . llvm Message-ID: <20190308192151.GI78397@spindle.one-eyed-alien.net> In-Reply-To: <4l8d-9p4w-wny@FreeBSD.org> References: <201903080040.x280ewF0084625@repo.freebsd.org> <CAP7rwciJ=pgiigGgDjutfRSLYV8qQYNaWuFckVDDyGypZMLjLw@mail.gmail.com> <20190308180601.GH78397@spindle.one-eyed-alien.net> <4l8d-9p4w-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--fCcDWlUEdh43YKr8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Fri, Mar 08, 2019 at 07:50:39PM +0100, Jan Beich wrote:
> Brooks Davis <brooks@freebsd.org> writes:
>=20
> > On Fri, Mar 08, 2019 at 06:03:55AM -0700, Adam Weinberger wrote:
> >
> >> On Thu, Mar 7, 2019 at 5:41 PM Brooks Davis <brooks@freebsd.org> wrote:
> >> >
> >> > It is intended for use by users and should not be a port build dep=
endency.
> >>=20
> >> Perhaps a comment near the top of the Makefile about this could be
> >> helpful. Right now there's nothing in the Makefile or pkg-descr to
> >> inform future porters of this important implementation detail.
> >
> > What I'd really like is a way to declare a port as ineligible to be a
> > dependency.
>=20
> Like the following?
>=20
> $ DEVELOPER=3D1 make check-sanity
> /!\ foo-0.1: Makefile errors /!\
>=20
> devel/llvm in BUILD_DEPENDS is unsupported, please use devel/llvm60 inste=
ad
>=20
> *** Error code 1
>=20
> Stop.
> make: stopped in /usr/ports/misc/foo
>=20
> --- Mk/bsd.sanity.mk.orig
> +++ Mk/bsd.sanity.mk
> @@ -70,6 +70,14 @@ DEV_WARNING+=3D "Not validating first entry in CATEGOR=
IES due to being outside of
> DEV_ERROR+=3D "USE_PERL5=3Dyes is unsupported, please use USES=3Dperl5 i=
nstead"
> .endif
> =20
> +.if !empty(BUILD_DEPENDS:M*devel/llvm)
> +DEV_ERROR+=3D "devel/llvm in BUILD_DEPENDS is unsupported, please use de=
vel/llvm${LLVM_DEFAULT} instead"
> +.endif
> +
> +.if !empty(BUILD_DEPENDS:M*lang/gcc)
> +DEV_ERROR+=3D "lang/gcc in BUILD_DEPENDS is unsupported, please use USE_=
GCC=3Dyes instead"
> +.endif
> +
> .if !empty(LIB_DEPENDS:M*/../*)
> DEV_ERROR+=3D "LIB_DEPENDS contains unsupported relative path to depende=
ncy"
> .endif
>=20
I'd like something like:
LEAF_PORT_BUILD=3D Ports should depend on explict devel/llvm## ports
LEAF_PORT_LIB=3D Ports should depend on explict devel/llvm## ports
-- Brooks
--fCcDWlUEdh43YKr8
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQEcBAEBAgAGBQJcgsDOAAoJEKzQXbSebgfAUs0H+gPfJ71/8ISjtHEme17t59/g
DetuwmuDb+uQH1NPYexYazcQA1FIlvX8YzWtTSTjwoq3N6gvnuiSN/ODIaWXGJb0
8qkZMrN4BFgpDgCrYLuC9OmffC2eMdVXroXUa1yh0lxfOKV/y2sQStWWW3GvEAeM
pryVjp30tPxmybiowlwzm9tNrK5xmYSgvn1IwM74o4dReDsV2GBfUVemQ5MODi0e
fLk2Eqdii18o3+Lixn8C3CmoBq9aZyRnbqOgizWczDC9kSVdR/EkAGnQusPfPnYM
M5gr0N0TozJvnyBXOWuXa3XeI1x84HLm5fMDs5IfRyNu5APjvEIqhp6HEubFux0=
=HMEW
-----END PGP SIGNATURE-----
--fCcDWlUEdh43YKr8--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190308192151.GI78397>