Date: Mon, 19 Jun 2023 21:45:16 -0700 From: Colin Percival <cperciva@freebsd.org> To: Warner Losh <imp@bsdimp.com> Cc: Ed Maste <emaste@freebsd.org>, src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: b908f6c45e02 - main - bsd.mkopt.mk: Add REQUIRED_OPTIONS list Message-ID: <b39d8e59-f685-3388-6e98-1df40ea4d7bd@freebsd.org> In-Reply-To: <CANCZdfpZ4ngq61d4qqScZ3D8yPw6m099d23T2O-imbwH0GVqtQ@mail.gmail.com> References: <202306200023.35K0NSlA057479@gitrepo.freebsd.org> <CAPyFy2AoPstPi7eMcbr3Vxp3J26QU8RrqpjP0yW2gQuDoe6z=w@mail.gmail.com> <CANCZdfpz87nXKw2-mQ0sOzW%2B%2Bv_k3_GtvVEd1vuRUTD5hNuGkQ@mail.gmail.com> <60984493-01fd-d02d-496e-1c973cdda2f7@freebsd.org> <CANCZdfpZ4ngq61d4qqScZ3D8yPw6m099d23T2O-imbwH0GVqtQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 6/19/23 20:46, Warner Losh wrote: > On Mon, Jun 19, 2023, 9:14 PM Colin Percival <cperciva@freebsd.org > <mailto:cperciva@freebsd.org>> wrote: > On 6/19/23 18:18, Warner Losh wrote: > > On Mon, Jun 19, 2023, 7:04 PM Ed Maste <emaste@freebsd.org > <mailto:emaste@freebsd.org> > > <mailto:emaste@freebsd.org <mailto:emaste@freebsd.org>>> wrote: > > On Mon, 19 Jun 2023 at 20:23, Colin Percival <cperciva@freebsd.org > <mailto:cperciva@freebsd.org> > > <mailto:cperciva@freebsd.org <mailto:cperciva@freebsd.org>>> wrote: > > > bsd.mkopt.mk <http://bsd.mkopt.mk>; <http://bsd.mkopt.mk > <http://bsd.mkopt.mk>>: Add REQUIRED_OPTIONS list > > > > > > Options on this list will be forced to 'yes'. This is > intended for use > > > as a transitional measure when an option is ceasing to be > optional, > > > before all of the associated make logic is removed. > > > > Should we emit a warning when an option is disabled in src.conf but > > specified in REQUIRED_OPTIONS? > > > > e.g. warning: WITHOUT_CAPSICUM option ignored: it is no longer > supported > > > > I asked for this in the review... I didn't approve the review because I > was > > waiting for an answer to the request. > > I'm happy to add such a warning, although I'm not sure how useful it would be > (unless we add a 'sleep 60' afterwards perhaps?), but I don't see any such > comments on the review... did phabricator eat it? > > > People will see it. No sleep needed. People read the logs. > > Maybe I was too subtle since we went down the does := work twice... D40613. -- Colin Percival FreeBSD Deputy Release Engineer & EC2 platform maintainer Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b39d8e59-f685-3388-6e98-1df40ea4d7bd>