Date: Sat, 4 Mar 2017 18:02:02 +0200 From: Andriy Gapon <avg@FreeBSD.org> To: Julian Elischer <julian@FreeBSD.org>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-stable@FreeBSD.org, svn-src-stable-10@FreeBSD.org Subject: Re: svn commit: r314667 - in stable/10/sys: amd64/amd64 cddl/contrib/opensolaris/uts/common/dtrace cddl/contrib/opensolaris/uts/common/fs/zfs cddl/dev/profile compat/ndis contrib/ipfilter/netinet dev/a... Message-ID: <47d091e5-6efe-5992-f09c-8c231f2da349@FreeBSD.org> In-Reply-To: <1292f504-21e4-1bee-3dd6-6205252bfd26@freebsd.org> References: <201703041303.v24D3Vfi072728@repo.freebsd.org> <1292f504-21e4-1bee-3dd6-6205252bfd26@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 04/03/2017 17:30, Julian Elischer wrote: > On 4/3/17 9:03 pm, Andriy Gapon wrote: >> Author: avg >> Date: Sat Mar 4 13:03:31 2017 >> New Revision: 314667 >> URL: https://svnweb.freebsd.org/changeset/base/314667 >> >> Log: >> MFC r283291: don't use CALLOUT_MPSAFE with callout_init() >> The main purpose of this MFC is to reduce conflicts for other merges. >> Parts of the original change have already "trickled down" via individual MFCs. > > is there a better name than ''1" when you replace " CALLOUT_MPSAFE"? Maybe 'true'. The argument has type int and it is documented this way: If the mpsafe argument is zero, the callout structure is not considered to be “multi-processor safe”; and the Giant lock will be acquired before calling the callout function and released when the callout function returns. >> - callout_init(&watchdog_callout, CALLOUT_MPSAFE); >> + callout_init(&watchdog_callout, 1); >> if (watchdog_cpu != -1) >> watchdog_change(watchdog_cpu); > -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?47d091e5-6efe-5992-f09c-8c231f2da349>