Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 27 Feb 2008 14:23:45 +0300
From:      Vsevolod Stakhov <vsevolod@highsecure.ru>
To:        Ryan Tomayko <rtomayko@gmail.com>
Cc:        ports@freebsd.org, "Sergey A. Osokin" <osa@FreeBSD.org>
Subject:   Re: nginx upstream_fair module patch
Message-ID:  <47C54841.3060601@highsecure.ru>
In-Reply-To: <47C46645.80700@gmail.com>
References:  <47C46645.80700@gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------000800060705070406080903
Content-Type: text/plain; charset=KOI8-R; format=flowed
Content-Transfer-Encoding: 7bit

Ryan Tomayko wrote:
> Hello Sergey,
> 
> There is an experimental module for nginx that adds fair upstream/proxy
> balancing (note that this is a "third party" patch, not an optional
> nginx module):
> 
>     http://wiki.codemongers.com/NginxHttpUpstreamFairModule
> 
> We've modified the nginx port to include the patch and added a knob for
> enabling it. I wasn't sure if this was something that's acceptable to
> include in the official nginx port but I've attached a patch in case
> you're interested.
> 
> The patch should apply cleanly with:
> 

I don't think that it is a good idea to have 3-rd party code as FreeBSD 
ports patches (ports patches are FreeBSD specific code). I think it 
would be better to have some directive for enabling extra modules for 
nginx and make subports for such modules, in the similar way as php 
ports for example.
Here is a small patch. Maybe this should be better done using OPTIONS.

--------------000800060705070406080903
Content-Type: text/x-patch;
 name="nginx-extra-modules.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="nginx-extra-modules.patch"

--- nginx-devel.old/Makefile	2008-01-24 15:46:37.000000000 +0300
+++ nginx-devel/Makefile	2008-01-24 15:46:49.000000000 +0300
@@ -145,6 +145,13 @@
 .include "${PORTSDIR}/Mk/bsd.openssl.mk"
 .endif
 
+# Add 3-rd party modules to nginx dist
+.if defined(WITH_EXTRA_MODULES)
+. for extra_module in ${WITH_EXTRA_MODULES:C/:/ /g}
+CONFIGURE_ARGS+=--add-module=${extra_module}
+. endfor
+.endif
+
 PLIST_SUB+=	NGINX_TMPDIR=${NGINX_TMPDIR} WWWOWN=${WWWOWN} WWWGRP=${WWWGRP}
 
 post-patch:

--------------000800060705070406080903--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?47C54841.3060601>