Date: Sun, 1 Sep 2019 12:33:59 -0700 From: Enji Cooper <yaneurabeya@gmail.com> To: Hans Petter Selasky <hps@selasky.org> Cc: Warner Losh <imp@bsdimp.com>, Ed Maste <emaste@freebsd.org>, FreeBSD Hackers <freebsd-hackers@freebsd.org>, Li-Wen Hsu <lwhsu@freebsd.org>, fcp@freebsd.org Subject: Re: FCP 20190401-ci_policy: CI policy Message-ID: <8350379A-30F8-4BBD-B9AE-A3A176CAE966@gmail.com> In-Reply-To: <44a1a905-9b35-620b-281c-cdbbee538bed@selasky.org> References: <CAKBkRUwKKPKwRvUs00ja0%2BG9vCBB1pKhv6zBS-F-hb=pqMzSxQ@mail.gmail.com> <20190829114057.GZ71821@kib.kiev.ua> <CAPyFy2BNrFfZ1PHaLesW%2Bu7YmbhC7mtiZ%2BBsYrqYE0J7KdagaA@mail.gmail.com> <20190830065534.GC71821@kib.kiev.ua> <CAPyFy2CXVMEXZx0u9b0p_CVaD_gu8Gyzvud3KwEDciq83a2_8A@mail.gmail.com> <73111.1567263258@kaos.jnpr.net> <CANCZdfqJzpxj7-P7XN7GEsECEA%2BLaUq6yQJ98OQUp_gXX9FF9Q@mail.gmail.com> <CAPyFy2CdddbDZYNod1ze1Z2iMyggSPP5kQV6ePeKSRQntezZEQ@mail.gmail.com> <CANCZdfoWAuSCKqFwWsnXTmznyuazHfy0tAfgZEv1m92MeSHAEg@mail.gmail.com> <44a1a905-9b35-620b-281c-cdbbee538bed@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Sep 1, 2019, at 10:42 AM, Hans Petter Selasky <hps@selasky.org> = wrote: >=20 > Hi, >=20 > If the fallouts could be better organized through some simple = guidelines, that would be more accepted I think: >=20 > 1) Don't commit stuff before going off work. Even though a change = looks innocent, it might break something and you'll need to fix it. >=20 > 2) Organize big changes going into the kernel, to ease debugging and = getting things back on track again. >=20 > 3) If your patch is risky, commit it on a Monday. Don't wait until = Friday. >=20 > Failure to follow the rules may have consequences like other senior = developers kicking in and doing temporary reverts until issues are = resolved. Agreed. There=E2=80=99s a reason why at my most former job (FB) we = generally knew better than to commit code on a Friday. It would cause = the weekend oncalls a lot of grief. Let=E2=80=99s put it this way: think of it like being oncall for code. = If you don=E2=80=99t have someone else to work with who can manage it, = would you like to be paged if something went south with your code = committed on a Friday? Cheers, -Enji=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8350379A-30F8-4BBD-B9AE-A3A176CAE966>