Date: Mon, 4 Nov 2013 22:43:40 +0100 From: Dimitry Andric <dim@FreeBSD.org> To: Sean Bruno <sbruno@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r257645 - head/gnu/lib/libgcc Message-ID: <57710455-9B81-47FF-926B-1075EB6F4290@FreeBSD.org> In-Reply-To: <201311041815.rA4IFjwO081492@svn.freebsd.org> References: <201311041815.rA4IFjwO081492@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 04 Nov 2013, at 19:15, Sean Bruno <sbruno@FreeBSD.org> wrote: > Author: sbruno > Date: Mon Nov 4 18:15:45 2013 > New Revision: 257645 > URL: http://svnweb.freebsd.org/changeset/base/257645 > > Log: > Quiesce warning around gcc_assert() for an inline macro that uses > a static variable. This code has been moved around in gcc, but is still in > use in the latest trunk version of the compiler. > > gnu/lib/libgcc/../../../contrib/gcc/unwind-dw2.c:208:36: > warning: static variable 'dwarf_reg_size_table' is used in an inline > function with external linkage [-Wstatic-in-inline] > gcc_assert (index < (int) sizeof(dwarf_reg_size_table)); The warning is actually correct, since _Unwind_SetGR() is an extern inline function (although it is not explicitly declared as such), but it does access a static variable. It would probably be safest to make the variable non-static instead, since the function itself cannot be changed to static inline. -Dimitry [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) iEYEARECAAYFAlJ4FRMACgkQsF6jCi4glqO4igCg9Vr9wCaeelvd6UebQQi8eBbM 3sEAn3lkNntcFJC6TROOsK2f+eANUvcB =w4Rn -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?57710455-9B81-47FF-926B-1075EB6F4290>