Date: Mon, 20 Oct 2003 08:48:53 +0100 From: David Malone <dwmalone@maths.tcd.ie> To: Scott Long <scottl@freebsd.org> Cc: cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/dev/streams streams.c src/sys/kernkern_descrip.c kern_event.c sys_pipe.c uipc_syscalls.cvfs_syscalls.c src/sys/opencrypto cryptodev.c Message-ID: <200310200848.aa99929@salmon.maths.tcd.ie> In-Reply-To: Your message of "Sun, 19 Oct 2003 19:41:11 MDT." <3F933D37.40906@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> > This reminds me that we still hold Giant around pipe(2) because it isn't > > declared MPSAFE in the syscall table. Is this still necessary? > I've been suspicious of this too, and I was hoping that you would have > an answer. Can we go ahead and correct this? I think we may need to check the calling of pipeclose() in pipe(), but as this is only done in an error case, it is probably safe enough to just grab Giant for that. (The mac_* calls may need to be checked too). > > Additionally, we declare dup2(2) to be MPSAFE, but not dup(2). Given > > their implementations that seems odd. > We likely need to do a review through the syscalls and weed out problems > like this. Any volunteers? I'm pretty sure dup not being marked MPSAFE is just a typo, based on the CVS logs. I'll change it later today. David.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200310200848.aa99929>