Date: Mon, 18 Mar 2002 04:19:01 -0800 From: "Crist J. Clark" <crist.clark@attbi.com> To: Dag-Erling Smorgrav <des@ofug.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/chpass chpass.c pw_copy.c pw_copy.h Message-ID: <20020318041901.A59516@blossom.cjclark.org> In-Reply-To: <20020318135824.A1326@straylight.oblivion.bg>; from roam@ringlet.net on Mon, Mar 18, 2002 at 01:58:24PM %2B0200 References: <200203180222.g2I2Ms309830@freefall.freebsd.org> <20020318135824.A1326@straylight.oblivion.bg>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 18, 2002 at 01:58:24PM +0200, Peter Pentchev wrote:
> On Sun, Mar 17, 2002 at 06:22:53PM -0800, Crist J. Clark wrote:
> > cjc 2002/03/17 18:22:53 PST
> >
> > Modified files:
> > usr.bin/chpass chpass.c pw_copy.c pw_copy.h
> > Log:
> > It was possible for an unprivileged user to tie up the password
> > information (no one else can vipw(8), chpass(1), or even passwd(1)),
> > either on purpose or by accident, until an administrator manually
> > intervened. Instead, do not lock the master.passwd file while a user
> > is editing his information. But once we go to write the new
> > information, check that the modified user's information has not
> > changed in the password database since we started. Abort the changes
> > if it has.
> >
> > Add a $FreeBSD$ to pw_copy.h.
> >
> > PR: i386/35816
> > Obtained from: NetBSD
> > MFC after: 1 week
>
> [des@ CC'd because of a proposed libpam patch]
>
> Errr... did this really go through a buildworld? :)
> I think that at least the attached patches are needed to catch up
> with pw_copy.c's including pw_scan.h and pw_copy()'s growing a fourth
> parameter..
Sorry, that kind of dependency never occurred to me. But I thought
they did survive a buildworld (not that I actually did it to check
these changes).
This is all quite a mess. We have chpass(8) using __pw_scan from libc
and source in vipw(8), and PAM modules sharing all of this code
too. Wouldn't the Right Thing be to put these functions in a library
somewhere? I think NetBSD has a lot of this stuffed in libutil.
Thanks for the patches. The PAM stuff look good, DES?
--
Crist J. Clark | cjclark@alum.mit.edu
| cjclark@jhu.edu
http://people.freebsd.org/~cjc/ | cjc@freebsd.org
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020318041901.A59516>