Date: Tue, 10 Jul 2012 09:52:35 -0700 From: Sean Bruno <seanbru@yahoo-inc.com> To: Fabian Keil <freebsd-listen@fabiankeil.de> Cc: "freebsd-hackers@FreeBSD.org" <freebsd-hackers@FreeBSD.org>, Sean Bruno <sbruno@FreeBSD.org>, Andriy Gapon <avg@FreeBSD.org>, "rmacklem@FreeBSD.org" <rmacklem@FreeBSD.org> Subject: Re: dtraceall.ko with old nfsclient Message-ID: <1341939155.2573.8.camel@powernoodle.corp.yahoo.com> In-Reply-To: <20120710154128.192eb8d6@fabiankeil.de> References: <1341863341.6064.11.camel@powernoodle.corp.yahoo.com> <4FFB4770.7050209@FreeBSD.org> <20120710154128.192eb8d6@fabiankeil.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 2012-07-10 at 06:41 -0700, Fabian Keil wrote: > > > > --- //depot/yahoo/ybsd_9/src/sys/modules/dtrace/dtraceall/dtraceall.c > > > 2011-11-02 23:46:55.000000000 0000 > > > > +++ /home/seanbru/dtrace_9/src/sys/modules/dtrace/dtraceall/dtraceall.c > > > 2011-11-02 23:46:55.000000000 0000 > > > @@ -66,8 +66,11 @@ > > > MODULE_DEPEND(dtraceall, opensolaris, 1, 1, 1); > > > MODULE_DEPEND(dtraceall, dtrace, 1, 1, 1); > > > MODULE_DEPEND(dtraceall, dtmalloc, 1, 1, 1); > > > +#if defined (NFSCL) > > > MODULE_DEPEND(dtraceall, dtnfscl, 1, 1, 1); > > > +#else /* defined (NFSCLIENT) */ > > Any objections to changing this to > #elif defined (NFSCLIENT) > ? No objections here. I suspect that this is the more correct thing regardless. I mean, it keeps the nfs dtrace objects loading in the event someone is running a non-nfs kernel... right? Sean
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1341939155.2573.8.camel>