Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 6 Feb 2023 00:51:59 +0800
From:      Po-Chuan Hsieh <sunpoet@freebsd.org>
To:        Po-Chuan Hsieh <sunpoet@freebsd.org>
Cc:        Charlie Li <vishwin@freebsd.org>, ports-committers@freebsd.org,  dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject:   Re: git: 8b6f38739d2f - main - devel/py-hatchling: Update to 1.12.2
Message-ID:  <CAMHz58SeSQ349bw-%2BjZ3uyTfS8G3_EY2brW3b%2BtEZNN3%2B1%2B%2B7w@mail.gmail.com>
In-Reply-To: <CAMHz58RwwHK4kAbSJ8GfRQznEYDDo09Og-mNNLGNhry0xoDG1w@mail.gmail.com>
References:  <202301301308.30UD8pf6056990@gitrepo.freebsd.org> <b9138f92-aa39-7527-d9e8-d3f532f56cec@freebsd.org> <CAMHz58RwwHK4kAbSJ8GfRQznEYDDo09Og-mNNLGNhry0xoDG1w@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000e435f005f3f6bd4a
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Feb 5, 2023 at 3:19 PM Po-Chuan Hsieh <sunpoet@freebsd.org> wrote:

> On Tue, Jan 31, 2023 at 8:06 AM Charlie Li <vishwin@freebsd.org> wrote:
>
>> Po-Chuan Hsieh wrote:
>> > The branch main has been updated by sunpoet:
>> >
>> > URL:
>> https://cgit.FreeBSD.org/ports/commit/?id=3D8b6f38739d2f582a2f8a0d3702e3=
5fbf1bb1b630
>> >
>> > commit 8b6f38739d2f582a2f8a0d3702e35fbf1bb1b630
>> > Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
>> > AuthorDate: 2023-01-30 12:31:22 +0000
>> > Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
>> > CommitDate: 2023-01-30 12:59:47 +0000
>> >
>> >      devel/py-hatchling: Update to 1.12.2
>> >
>> >      Changes:
>> https://github.com/pypa/hatch/commits/master/backend
>> > ---
>> >   devel/py-hatchling/Makefile       |  5 +++--
>> >   devel/py-hatchling/distinfo       |  6 +++---
>> >   devel/py-hatchling/files/setup.py | 23 +++++++++--------------
>> >   3 files changed, 15 insertions(+), 19 deletions(-)
>> >
>> This, along with other ports, are to have USE_PYTHON=3Dpep517 and setup.=
py
>> removed.
>>
>
> Thanks for your work,
> I'll check the pep517 implementation. If it's ready, I'll start convertin=
g
> my ports to it.
>

I've read the pep517 implementation.
The first issue I noticed was about not installing the bytecode.
It is failing poudriere builds with build_fs_violation.
e.g.
from py-sphinx log:
=3D>> Checking for staging violations... done
=3D>> Error: Filesystem touched during stage (files must install to
${STAGEDIR}):
extra: usr/local/lib/python3.9/site-packages/importlib_metadata/__pycache__
=3D>> Cleaning up wrkdir

I guess it was not noticed before because currently most of the ports using
pep517 are leaf ports.
But it is not the case after py-importlib-metadata converted to pep517.

I've prepared a patch to fix this.

Regards,
sunpoet


>
>> --
>> Charlie Li
>> =E2=80=A6nope, still don't have an exit line.
>>
>>
>>

--000000000000e435f005f3f6bd4a
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Sun, Feb 5, 2023 at 3:19 PM Po-Chuan H=
sieh &lt;<a href=3D"mailto:sunpoet@freebsd.org" target=3D"_blank">sunpoet@f=
reebsd.org</a>&gt; wrote:<br></div><div class=3D"gmail_quote"><blockquote c=
lass=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px soli=
d rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr">On T=
ue, Jan 31, 2023 at 8:06 AM Charlie Li &lt;<a href=3D"mailto:vishwin@freebs=
d.org" target=3D"_blank">vishwin@freebsd.org</a>&gt; wrote:<br></div><div c=
lass=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"margin:0px =
0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Po-C=
huan Hsieh wrote:<br>
&gt; The branch main has been updated by sunpoet:<br>
&gt; <br>
&gt; URL: <a href=3D"https://cgit.FreeBSD.org/ports/commit/?id=3D8b6f38739d=
2f582a2f8a0d3702e35fbf1bb1b630" rel=3D"noreferrer" target=3D"_blank">https:=
//cgit.FreeBSD.org/ports/commit/?id=3D8b6f38739d2f582a2f8a0d3702e35fbf1bb1b=
630</a><br>
&gt; <br>
&gt; commit 8b6f38739d2f582a2f8a0d3702e35fbf1bb1b630<br>
&gt; Author:=C2=A0 =C2=A0 =C2=A0Po-Chuan Hsieh &lt;sunpoet@FreeBSD.org&gt;<=
br>
&gt; AuthorDate: 2023-01-30 12:31:22 +0000<br>
&gt; Commit:=C2=A0 =C2=A0 =C2=A0Po-Chuan Hsieh &lt;sunpoet@FreeBSD.org&gt;<=
br>
&gt; CommitDate: 2023-01-30 12:59:47 +0000<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0 devel/py-hatchling: Update to 1.12.2<br>
&gt;=C2=A0 =C2=A0 =C2=A0 <br>
&gt;=C2=A0 =C2=A0 =C2=A0 Changes:=C2=A0 =C2=A0 =C2=A0 =C2=A0 <a href=3D"htt=
ps://github.com/pypa/hatch/commits/master/backend" rel=3D"noreferrer" targe=
t=3D"_blank">https://github.com/pypa/hatch/commits/master/backend</a><br>;
&gt; ---<br>
&gt;=C2=A0 =C2=A0devel/py-hatchling/Makefile=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=
=A0 5 +++--<br>
&gt;=C2=A0 =C2=A0devel/py-hatchling/distinfo=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=
=A0 6 +++---<br>
&gt;=C2=A0 =C2=A0devel/py-hatchling/files/setup.py | 23 +++++++++----------=
----<br>
&gt;=C2=A0 =C2=A03 files changed, 15 insertions(+), 19 deletions(-)<br>
&gt; <br>
This, along with other ports, are to have USE_PYTHON=3Dpep517 and setup.py =
<br>
removed.<br></blockquote><div><br></div><div>Thanks for your work,</div><di=
v>I&#39;ll check the pep517 implementation. If it&#39;s ready, I&#39;ll sta=
rt converting my ports to it.<br></div></div></div></blockquote><div><br></=
div><div>I&#39;ve read the pep517 implementation.</div><div>The first issue=
 I noticed was about not installing the=C2=A0bytecode.</div><div>It is fail=
ing poudriere builds with build_fs_violation.<br></div><div>e.g.</div><div>=
from py-sphinx log:<br>=3D&gt;&gt; Checking for staging violations... done<=
br>=3D&gt;&gt; Error: Filesystem touched during stage (files must install t=
o ${STAGEDIR}):<br>extra: usr/local/lib/python3.9/site-packages/importlib_m=
etadata/__pycache__<br>=3D&gt;&gt; Cleaning up wrkdir<br></div><div><br></d=
iv><div>I guess it was not noticed before because currently most of the por=
ts using pep517 are leaf ports.</div><div>But it is not the case after py-i=
mportlib-metadata converted to pep517.</div><div><br></div><div>I&#39;ve pr=
epared a patch to fix this.</div><div><br></div><div>Regards,</div><div>sun=
poet</div><div><br></div><blockquote class=3D"gmail_quote" style=3D"margin:=
0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">=
<div dir=3D"ltr"><div class=3D"gmail_quote"><div></div><div><br></div><bloc=
kquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:=
1px solid rgb(204,204,204);padding-left:1ex">
<br>
-- <br>
Charlie Li<br>
=E2=80=A6nope, still don&#39;t have an exit line.<br>
<br>
</blockquote><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px =
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br></blockq=
uote></div></div>
</blockquote></div></div>

--000000000000e435f005f3f6bd4a--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58SeSQ349bw-%2BjZ3uyTfS8G3_EY2brW3b%2BtEZNN3%2B1%2B%2B7w>