Skip site navigation (1)Skip section navigation (2) 
Date:      Thu, 05 Jul 2018 20:36:39 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 229552] src/sys/net/if_me.c:522]: (style) Suspicious condition
Message-ID:  <bug-229552-227@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help 

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229552

            Bug ID: 229552
           Summary: src/sys/net/if_me.c:522]: (style) Suspicious condition
           Product: Base System
           Version: CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: kern
          Assignee: bugs@FreeBSD.org
          Reporter: dcb314@hotmail.com

src/sys/net/if_me.c:522]: (style) Suspicious condition (assignment +
comparison); Clarify expression with parentheses.

Source code is

       if (sc == NULL || !ME_READY(sc) ||
            (ifp->if_flags & IFF_MONITOR) != 0 ||
            (ifp->if_flags & IFF_UP) == 0 ||
            (error = me_check_nesting(ifp, m) != 0)) {

maybe better code

       if (sc == NULL || !ME_READY(sc) ||
            (ifp->if_flags & IFF_MONITOR) != 0 ||
            (ifp->if_flags & IFF_UP) == 0 ||
            (error = me_check_nesting(ifp, m)) != 0) {

-- 
You are receiving this mail because:
You are the assignee for the bug.

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-229552-227>