Date: Sun, 29 Jul 2001 14:59:17 -0700 From: Kris Kennaway <kris@obsecurity.org> To: David O'Brien <obrien@FreeBSD.ORG> Cc: freebsd-hackers@FreeBSD.ORG Subject: Re: [PATCH] reduce text(code) size and improve clarity of pkg_add Message-ID: <20010729145916.D94563@xor.obsecurity.org> In-Reply-To: <20010727214412.A91434@dragon.nuxi.com>; from obrien@FreeBSD.ORG on Fri, Jul 27, 2001 at 09:44:12PM -0700 References: <20010727214412.A91434@dragon.nuxi.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --]
On Fri, Jul 27, 2001 at 09:44:12PM -0700, David O'Brien wrote:
> I'd like to apply this patch to pkg_add which reduces the amount of code
> the compiler generates, and improves the clarity of the code.
>
> 1. s_strl* is obvious some form of "safe" strl{cpy,cat}. But *WHAT*
> does it make "safe"? Isn't obvious w/o having to track down the
> s_strl{cat,cpy} function definitions.
>
> 2. The current code has more function call overhead than is needed. And
> it reduces the size of the basic block for the optimizer to work on.
> It also potentially has cache miss penalties.
I now think these should be macros which do the if() test and the errx.
Kris
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (FreeBSD)
Comment: For info see http://www.gnupg.org
iD8DBQE7ZIc0Wry0BWjoQKURAqy2AKDGw4Aokoqb+9GwJIBvtRTwKSA/lgCgztHu
hz8Ki8NtiKQ+3wDb015cJiI=
=w8eC
-----END PGP SIGNATURE-----
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010729145916.D94563>