Date: Sat, 08 Mar 1997 15:31:57 +0000 From: Brian Somers <brian@awfulhak.demon.co.uk> To: "Andrey A. Chernov" <ache@freebsd.org> Cc: CVS-committers@freebsd.org, cvs-all@freebsd.org, cvs-usrsbin@freebsd.org Subject: Re: cvs commit: src/usr.sbin/ppp timer.c Message-ID: <199703081531.PAA12796@awfulhak.demon.co.uk> In-Reply-To: Your message of "Sat, 08 Mar 1997 01:55:44 PST." <199703080955.BAA03844@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> ache 97/03/08 01:55:43
>
> Modified: usr.sbin/ppp timer.c
> Log:
> Don't pend SIGALRM (Timer Service) due to
> 1) When carrier dropped, old variant often forget to detect it cause
> unkillable loop forever (because SIGTERM pended too, but it will be
> separate commit)
> 2) Time intervals accuracy reasons
>
> Should go into 2.2
>
> Revision Changes Path
> 1.11 +3 -3 src/usr.sbin/ppp/timer.c
>
The only time the code can "forget" to pend a signal is if it gets caused
during the call to pending_signal() (between the signal() call and the
caused &= bit).
This change is going to re-invent the recursive malloc() problem (or
am I missing something?).
--
Brian <brian@awfulhak.demon.co.uk>, <brian@freebsd.org>
<http://www.awfulhak.demon.co.uk/>;
Don't _EVER_ lose your sense of humour....
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199703081531.PAA12796>