Date: Sat, 1 Nov 2025 18:08:13 +0000 From: Jessica Clarke <jrtc27@freebsd.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: Robert Clausecker <fuz@fuz.su>, Robert Clausecker <fuz@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 63ff982b17ee - main - simd.7: add scalar strrchr() for RISC-V to manpage Message-ID: <CEDBD5A2-D8E0-48E8-93C1-BE5970D8A492@freebsd.org> In-Reply-To: <aQZKz2RxIdu9_BpG@kib.kiev.ua> References: <202510311248.59VCmSpY042422@gitrepo.freebsd.org> <aQWBBSwq9_-46kiB@kib.kiev.ua> <aQXlc3_zVilCJevN@fuz.su> <aQZKz2RxIdu9_BpG@kib.kiev.ua>
index | next in thread | previous in thread | raw e-mail
On 1 Nov 2025, at 18:00, Konstantin Belousov <kostikbel@gmail.com> wrote:
>
> On Sat, Nov 01, 2025 at 11:48:19AM +0100, Robert Clausecker wrote:
>> Hi kib,
>>
>> Am Sat, Nov 01, 2025 at 05:39:49AM +0200 schrieb Konstantin Belousov:
>>> On Fri, Oct 31, 2025 at 12:48:28PM +0000, Robert Clausecker wrote:
>>>> #include <machine/asm.h>
>>>>
>>>> + .weak rindex
>>>> + .set rindex, strrchr
>>>> +
>>> Was this alias addition intended?
>>
>> Yes, this is intentional. See also lib/lib/{aarch64,amd64}/string/strrchr.S.
>
> Ok, let me reformulate my question.
> Was the 'rindex' symbol exported from libc on riscv before your commit?
>
> I remember that there was some effort to not provide 'obsoleted' exports
> from libc on the new arches like aarch64 and riscv.
It was exported prior to the series; see the last line in
lib/libc/string/strrchr.c and the unconditional entry in the
corresponding Symbol.map.
The mistake was making it a part of this commit rather than the one
that introduced a RISC-V strrchr.S, as the history is now a bit messed
up and confusing.
Jessica
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CEDBD5A2-D8E0-48E8-93C1-BE5970D8A492>