Date: Mon, 23 Jan 2012 12:16:38 +0100 From: =?ISO-8859-1?Q?Ermal_Lu=E7i?= <eri@freebsd.org> To: =?ISO-8859-1?Q?Tilman_Keskin=F6z?= <arved@freebsd.org> Cc: bug-followup@freebsd.org, freebsd-pf@freebsd.org Subject: Re: kern/163208: [pf] PF state key linking mismatch Message-ID: <CAPBZQG0dXLuiECjLQdP6N_WZJwUryhNpCCqozOf=wheS-aoc7Q@mail.gmail.com> In-Reply-To: <4F1BE7C8.4040601@FreeBSD.org> References: <4E4D073F-9979-4CB1-A421-DA5C1FC7A34F@FreeBSD.org> <20120121210118.0a1dc9d3@fabiankeil.de> <AB684E27-BE0B-429D-8077-2EE67A0E731B@freebsd.org> <69ABD828-70EB-4599-A3A0-52707C7F3DE5@lists.zabbadoz.net> <4F1BE7C8.4040601@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jan 22, 2012 at 11:41 AM, Tilman Keskin=F6z <arved@freebsd.org> wro= te: > * Bjoern A. Zeeb [Sat, 21 Jan 2012 21:01:41 +0000]: > > > > On 21. Jan 2012, at 20:52 , Tilman Keskin=F6z wrote: > > > >> > >> On Jan 21, 2012, at 21:01 , Fabian Keil wrote: > >> > >>> Tilman Keskin=F6z <arved@FreeBSD.org> wrote: > >>> > >>>> Same here. > >>>> > >>>> Also Fabian Keil reported this in > >>>> > http://lists.freebsd.org/pipermail/freebsd-current/2011-July/025696.html > >>> > >>> This has been fixed in CURRENT shortly thereafter: > >>> http://lists.freebsd.org/pipermail/freebsd-pf/2011-July/006199.html > >>> > >>> Maybe the fix hasn't been MFC'd. > >> > >> Hm, r223765 happend before the RELENG_9 Branchpoint. > >> So maybe the Fix was not complete? > > > > See thread from earlier this month on freebsd-pf > > > > The Thread suggests: > > * Matt Lager [Thu, 12 Jan 2012 15:48:23 -0700]: > > So it looks likeI can comment out this code in > > /usr/src/sys/contrib/pf/net/pf.c: > > > > /* mismatch. must not happen. */ > > printf("pf: state key linking mismatch! dir=3D%s, " > > "if=3D%s, stored af=3D%u, a0: ", > > dir =3D=3D PF_OUT ? "OUT" : "IN", kif->pfik_name, a= ->af); > > > > When this error occurs, I guess for valid reasons, does PF drop packets > > or do something else with them, or is this purely an information notic= e? > > I can confirm that removing this printf, brings back the performance for > me. > > Probably a sysctl to disable this should be provided. There might be unexpected consequences from this and the better fix is to find the section where the mbuf is being reused. > Please fix :) > > _______________________________________________ > freebsd-pf@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-pf > To unsubscribe, send any mail to "freebsd-pf-unsubscribe@freebsd.org" > --=20 Ermal
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPBZQG0dXLuiECjLQdP6N_WZJwUryhNpCCqozOf=wheS-aoc7Q>