Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 22 Jun 2004 21:04:35 -0400 (EDT)
From:      Robert Watson <rwatson@freebsd.org>
To:        Bruce M Simpson <bms@spc.org>
Cc:        freebsd-net@freebsd.org
Subject:   Re: kern/45733: file descriptor flags and socket flags out of sync
Message-ID:  <Pine.NEB.3.96L.1040622210340.61099E-100000@fledge.watson.org>
In-Reply-To: <20040623005802.GO762@empiric.dek.spc.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On Wed, 23 Jun 2004, Bruce M Simpson wrote:

> On Tue, Jun 22, 2004 at 07:11:19PM -0400, Robert Watson wrote:
> > 	so->so_state |= (head->so_state & SS_NBIO);
> 
> In the end this is what it boils down to. I've committed this and an
> appropriate manual page update. 

Since you're looking at the propagation of head so_state to new socket
so_state, you might want to look at the similar statement in sonewconn(),
which copies so_state from head to the new socket, and adds the SS_NOFDREF
flag.  Should we only be propagating SS_NBIO here as well?

Robert N M Watson             FreeBSD Core Team, TrustedBSD Projects
robert@fledge.watson.org      Senior Research Scientist, McAfee Research




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1040622210340.61099E-100000>