Date: Mon, 20 Feb 2012 12:08:38 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Mikolaj Golub <trociny@freebsd.org> Cc: "Robert N. M. Watson" <rwatson@freebsd.org>, freebsd-arch@freebsd.org Subject: Re: unix domain sockets on nullfs(5) Message-ID: <20120220100837.GA3283@deviant.kiev.zoral.com.ua> In-Reply-To: <8662f1q3lo.fsf@in138.ua3> References: <CAOnPXZ_y5G6uEBWmfuH7qYBh%2B4Pw=O91ztCPEFCOTzWdCzx%2BRA@mail.gmail.com> <BBDE763A-F55E-453D-A503-2489C9040EF6@freebsd.org> <20120112215106.GC31224@deviant.kiev.zoral.com.ua> <86hazntwmu.fsf@kopusha.home.net> <20120123031238.GL31224@deviant.kiev.zoral.com.ua> <86zkcfu9ac.fsf@kopusha.home.net> <20120218215003.GM3283@deviant.kiev.zoral.com.ua> <86ehtrf8qf.fsf@kopusha.home.net> <20120219170151.GS3283@deviant.kiev.zoral.com.ua> <8662f1q3lo.fsf@in138.ua3>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Mon, Feb 20, 2012 at 11:02:59AM +0200, Mikolaj Golub wrote: > > On Sun, 19 Feb 2012 19:01:51 +0200 Konstantin Belousov wrote: > > KB> On Sun, Feb 19, 2012 at 11:55:20AM +0200, Mikolaj Golub wrote: > >> > >> Unfortunately, vnode_if.awk does not support underscores in VOP names. It > >> failed with "Invalid %% construction" due to the restriction: $2 !~ /^[a-z]+$/. > >> So I reverted back to the old naming. > KB> Ok, might be it makes sense to try to add underscore to the set of > KB> allowed symbols. > > It does not look difficult and the patch is trivial: > > http://people.freebsd.org/~trociny/vnode_if.awk.patch > > I built and booted the kernel with VOP_UNP_* using it. > > I could commit if other people are ok with this and don't see issues. I cannot imagine a failure from this change. [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk9CG6UACgkQC3+MBN1Mb4h3uwCg8PodgFkal5XIGlq2UQu11kIn uGMAoNlKBATuEZWaedhdZB7YVynsl3ZX =gNmd -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120220100837.GA3283>