Date: Sat, 25 Feb 2017 20:12:42 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-mips@FreeBSD.org Subject: [Bug 216831] [PATCH] sys/mips/cavium/octeon_machdep.c: add cavium octeon 'bootoctlinux' boot argument support Message-ID: <bug-216831-27794-UmQ4muaYWP@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-216831-27794@https.bugs.freebsd.org/bugzilla/> References: <bug-216831-27794@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D216831 Juli Mallett <jmallett@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jmallett@FreeBSD.org --- Comment #7 from Juli Mallett <jmallett@FreeBSD.org> --- Hey Dave, A couple of minor thoughts on your patch: 1. Maybe don't assume the starting argument index. I'm pretty sure you can pass arguments just fine even if coremask is absent, or am I misremembering= ?=20 It's been awhile since I had to deal with it, honestly. You could easily enough do strcmp on the n from strsep to ignore those parameters. 2. If you do want to add boothowto_parse, which is a fine idea in my opinio= n, please make the passed parameter const! Thanks very much for doing this! --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-216831-27794-UmQ4muaYWP>