Date: Thu, 24 Oct 2013 21:11:12 -0400 From: Sean Bruno <sean_bruno@yahoo.com> To: "freebsd-hackers@freebsd.org" <freebsd-hackers@freebsd.org> Subject: Re: gperf -- #define for if (0) ; else for Message-ID: <1382663472.2498.2.camel@localhost> In-Reply-To: <1382327705.2610.9.camel@localhost> References: <1382327705.2610.9.camel@localhost>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Sun, 2013-10-20 at 23:55 -0400, Sean Bruno wrote: > I don't even know why this is a thing in our code base. Its generating > a lot of clang noise due to -Wdangling-else > > /usr/src/gnu/usr.bin/gperf/../../../contrib/gperf/src/search.cc:417:15: > warning: add explicit braces to avoid dangling else [-Wdangling-else] > for (int i3 = imax; i3 >= 0; i3--) > ^ > /usr/src/gnu/usr.bin/gperf/../../../contrib/gperf/src/search.cc:39:22: > note: expanded from macro 'for' > #define for if (0) ; else for > ^ > > I see no reason to continue this and propose the removal of the line in > contrib/gperf/src/search.cc > > 37 > 38 /* Assume ISO C++ 'for' scoping rule. */ > 39 #define for if (0) ; else for > > Commented out at svn R257085 sean [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iQEcBAABAgAGBQJSacUwAAoJEBkJRdwI6BaHHtsIAICBdJVQuWgFGoj7lT/dRSw9 KpVARzx6t14bOkE8jW0oUqmwC8qsvb3KBkRVqhvHYLwmP+2OmIulEbiLwkwKzw8W nGdXSv2Nz3IoZR1AxLCyo6dxvd2f0b+D5Mo0K3u7IuMSARuL444VN7HCoTj/Y+IO xPpV49aMM3O9LxuBqPwGVyQkGgzP43nskZRaQTHZVrODNBilhKQRhj72JdlLMF4J GJkHEC2BlDWqZq7a1r/jdVJ7QY94Cu2eoVIa9fEchyZhYYY8bFrNcK0vNCcL9EwM gZuTNQEq7s2AfTWUqliknIhhnfTxlAihFOLvVKLTAKNm04/P0qB/mZo4dZercoA= =cOef -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1382663472.2498.2.camel>