Date: Mon, 6 Feb 2023 00:51:59 +0800 From: Po-Chuan Hsieh <sunpoet@freebsd.org> To: Po-Chuan Hsieh <sunpoet@freebsd.org> Cc: Charlie Li <vishwin@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 8b6f38739d2f - main - devel/py-hatchling: Update to 1.12.2 Message-ID: <CAMHz58SeSQ349bw-%2BjZ3uyTfS8G3_EY2brW3b%2BtEZNN3%2B1%2B%2B7w@mail.gmail.com> In-Reply-To: <CAMHz58RwwHK4kAbSJ8GfRQznEYDDo09Og-mNNLGNhry0xoDG1w@mail.gmail.com> References: <202301301308.30UD8pf6056990@gitrepo.freebsd.org> <b9138f92-aa39-7527-d9e8-d3f532f56cec@freebsd.org> <CAMHz58RwwHK4kAbSJ8GfRQznEYDDo09Og-mNNLGNhry0xoDG1w@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Sun, Feb 5, 2023 at 3:19 PM Po-Chuan Hsieh <sunpoet@freebsd.org> wrote: > On Tue, Jan 31, 2023 at 8:06 AM Charlie Li <vishwin@freebsd.org> wrote: > >> Po-Chuan Hsieh wrote: >> > The branch main has been updated by sunpoet: >> > >> > URL: >> https://cgit.FreeBSD.org/ports/commit/?id=8b6f38739d2f582a2f8a0d3702e35fbf1bb1b630 >> > >> > commit 8b6f38739d2f582a2f8a0d3702e35fbf1bb1b630 >> > Author: Po-Chuan Hsieh <sunpoet@FreeBSD.org> >> > AuthorDate: 2023-01-30 12:31:22 +0000 >> > Commit: Po-Chuan Hsieh <sunpoet@FreeBSD.org> >> > CommitDate: 2023-01-30 12:59:47 +0000 >> > >> > devel/py-hatchling: Update to 1.12.2 >> > >> > Changes: >> https://github.com/pypa/hatch/commits/master/backend >> > --- >> > devel/py-hatchling/Makefile | 5 +++-- >> > devel/py-hatchling/distinfo | 6 +++--- >> > devel/py-hatchling/files/setup.py | 23 +++++++++-------------- >> > 3 files changed, 15 insertions(+), 19 deletions(-) >> > >> This, along with other ports, are to have USE_PYTHON=pep517 and setup.py >> removed. >> > > Thanks for your work, > I'll check the pep517 implementation. If it's ready, I'll start converting > my ports to it. > I've read the pep517 implementation. The first issue I noticed was about not installing the bytecode. It is failing poudriere builds with build_fs_violation. e.g. from py-sphinx log: =>> Checking for staging violations... done =>> Error: Filesystem touched during stage (files must install to ${STAGEDIR}): extra: usr/local/lib/python3.9/site-packages/importlib_metadata/__pycache__ =>> Cleaning up wrkdir I guess it was not noticed before because currently most of the ports using pep517 are leaf ports. But it is not the case after py-importlib-metadata converted to pep517. I've prepared a patch to fix this. Regards, sunpoet > >> -- >> Charlie Li >> …nope, still don't have an exit line. >> >> >> [-- Attachment #2 --] <div dir="ltr"><div dir="ltr">On Sun, Feb 5, 2023 at 3:19 PM Po-Chuan Hsieh <<a href="mailto:sunpoet@freebsd.org" target="_blank">sunpoet@freebsd.org</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr">On Tue, Jan 31, 2023 at 8:06 AM Charlie Li <<a href="mailto:vishwin@freebsd.org" target="_blank">vishwin@freebsd.org</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Po-Chuan Hsieh wrote:<br> > The branch main has been updated by sunpoet:<br> > <br> > URL: <a href="https://cgit.FreeBSD.org/ports/commit/?id=8b6f38739d2f582a2f8a0d3702e35fbf1bb1b630" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/ports/commit/?id=8b6f38739d2f582a2f8a0d3702e35fbf1bb1b630</a><br> > <br> > commit 8b6f38739d2f582a2f8a0d3702e35fbf1bb1b630<br> > Author: Po-Chuan Hsieh <sunpoet@FreeBSD.org><br> > AuthorDate: 2023-01-30 12:31:22 +0000<br> > Commit: Po-Chuan Hsieh <sunpoet@FreeBSD.org><br> > CommitDate: 2023-01-30 12:59:47 +0000<br> > <br> > devel/py-hatchling: Update to 1.12.2<br> > <br> > Changes: <a href="https://github.com/pypa/hatch/commits/master/backend" rel="noreferrer" target="_blank">https://github.com/pypa/hatch/commits/master/backend</a><br> > ---<br> > devel/py-hatchling/Makefile | 5 +++--<br> > devel/py-hatchling/distinfo | 6 +++---<br> > devel/py-hatchling/files/setup.py | 23 +++++++++--------------<br> > 3 files changed, 15 insertions(+), 19 deletions(-)<br> > <br> This, along with other ports, are to have USE_PYTHON=pep517 and setup.py <br> removed.<br></blockquote><div><br></div><div>Thanks for your work,</div><div>I'll check the pep517 implementation. If it's ready, I'll start converting my ports to it.<br></div></div></div></blockquote><div><br></div><div>I've read the pep517 implementation.</div><div>The first issue I noticed was about not installing the bytecode.</div><div>It is failing poudriere builds with build_fs_violation.<br></div><div>e.g.</div><div>from py-sphinx log:<br>=>> Checking for staging violations... done<br>=>> Error: Filesystem touched during stage (files must install to ${STAGEDIR}):<br>extra: usr/local/lib/python3.9/site-packages/importlib_metadata/__pycache__<br>=>> Cleaning up wrkdir<br></div><div><br></div><div>I guess it was not noticed before because currently most of the ports using pep517 are leaf ports.</div><div>But it is not the case after py-importlib-metadata converted to pep517.</div><div><br></div><div>I've prepared a patch to fix this.</div><div><br></div><div>Regards,</div><div>sunpoet</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <br> -- <br> Charlie Li<br> …nope, still don't have an exit line.<br> <br> </blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br></blockquote></div></div> </blockquote></div></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58SeSQ349bw-%2BjZ3uyTfS8G3_EY2brW3b%2BtEZNN3%2B1%2B%2B7w>
