Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 13 Jun 2022 16:03:51 +0000
From:      bugzilla-noreply@freebsd.org
To:        fs@FreeBSD.org
Subject:   [Bug 252316] [PATCH] add OCF offloading to ZFS
Message-ID:  <bug-252316-3630-jh09SNj4X1@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-252316-3630@https.bugs.freebsd.org/bugzilla/>
References:  <bug-252316-3630@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D252316

--- Comment #7 from John Baldwin <jhb@FreeBSD.org> ---
This looks good to me.  I would perhaps adjust the assertion message for the
digest case as the existing messages tell you what is wrong vs what is righ=
t,
so maybe something like "output digest is not at offset 0" or some such?

There is probably some room to add some other assertions if not present alr=
eady
such as rejecting separate output buffers for requests that want to verify a
digest vs computing a digest.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-252316-3630-jh09SNj4X1>