Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 15 Aug 2023 15:58:02 GMT
From:      Ed Maste <emaste@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 14e78a3656ef - main - ssh: Remove note about memory leak now resolved upstream
Message-ID:  <202308151558.37FFw2dn059066@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by emaste:

URL: https://cgit.FreeBSD.org/src/commit/?id=14e78a3656efef8f3cbacbab9c0653dff3f925f4

commit 14e78a3656efef8f3cbacbab9c0653dff3f925f4
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2023-08-15 15:54:09 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2023-08-15 15:56:08 +0000

    ssh: Remove note about memory leak now resolved upstream
    
    OpenSSH 9.4p1 (updated in commit 535af610a4fd) includes the memory leak
    fix that we originally applied in 69c72a57af84 ("sftp: avoid leaking
    path arg in calls to make_absolute_pwd_glob.").
    
    Sponsored by:   The FreeBSD Foundation
---
 crypto/openssh/FREEBSD-upgrade | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/crypto/openssh/FREEBSD-upgrade b/crypto/openssh/FREEBSD-upgrade
index 8d3f3a14f823..2950731c7401 100644
--- a/crypto/openssh/FREEBSD-upgrade
+++ b/crypto/openssh/FREEBSD-upgrade
@@ -171,21 +171,12 @@
    A number of paths are changed to match FreeBSD's configuration (e.g.,
    using /usr/local/ instead of /uxr/X11R6/).
 
-10) Memory leaks
-
-   Coverity reported a memory leak for which we proposed a fix in
-   https://reviews.freebsd.org/D37253 and sent to the upstream mailing list at
-   https://lists.mindrot.org/pipermail/openssh-unix-dev/2022-November/040497.html
-
-   Upstream subsequently fixed only one of the related leaks, so we reverted
-   the partial fix and applied our change.
-
-11) Retired patches
+10) Retired patches
 
    We no longer have client-side VersionAddendum, but we recognize and ignore
    the configuration options to avoid breaking existing configurations.
 
-12) PrintLastLog bugfix
+11) PrintLastLog bugfix
 
    Upstream's autoconf sets DISABLE_LASTLOG if the system does not have
    lastlog.ll_line, but uses it to disable the PrintLastLog configuration



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202308151558.37FFw2dn059066>