Date: Fri, 14 Oct 2016 10:26:41 -0700 From: Oleksandr Tymoshenko <gonzo@freebsd.org> To: Andrew Turner <andrew@fubar.geek.nz> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r307252 - head/sys/arm/broadcom/bcm2835 Message-ID: <D7AD0E83-F39B-4AAF-AACE-2C42A4E68529@freebsd.org> In-Reply-To: <20161014093726.197f8e05@zapp> References: <201610140300.u9E30r1O061196@repo.freebsd.org> <20161014093726.197f8e05@zapp>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Oct 14, 2016, at 1:37 AM, Andrew Turner <andrew@fubar.geek.nz> wrote: > > On Fri, 14 Oct 2016 03:00:53 +0000 (UTC) > Oleksandr Tymoshenko <gonzo@FreeBSD.org> wrote: > >> Author: gonzo >> Date: Fri Oct 14 03:00:53 2016 >> New Revision: 307252 >> URL: https://svnweb.freebsd.org/changeset/base/307252 >> >> Log: >> Make bcm2835_machdep.c optional >> >> bcm2835_machdep.c contains only bits enabled by "options PLATFORM", >> this option available only on ARM, not ARM64 >> >> Modified: >> head/sys/arm/broadcom/bcm2835/files.bcm283x >> >> Modified: head/sys/arm/broadcom/bcm2835/files.bcm283x >> ============================================================================== >> --- head/sys/arm/broadcom/bcm2835/files.bcm283x Fri Oct 14 02:58:31 2016 (r307251) >> +++ head/sys/arm/broadcom/bcm2835/files.bcm283x Fri Oct 14 03:00:53 2016 (r307252) >> @@ -9,7 +9,7 @@ arm/broadcom/bcm2835/bcm2835_fbd.c opti >> arm/broadcom/bcm2835/bcm2835_ft5406.c optional evdev bcm2835_ft5406 >> arm/broadcom/bcm2835/bcm2835_gpio.c optional gpio >> arm/broadcom/bcm2835/bcm2835_intr.c standard >> -arm/broadcom/bcm2835/bcm2835_machdep.c standard >> +arm/broadcom/bcm2835/bcm2835_machdep.c optional platform >> arm/broadcom/bcm2835/bcm2835_mbox.c standard >> arm/broadcom/bcm2835/bcm2835_rng.c optional random >> arm/broadcom/bcm2835/bcm2835_sdhci.c optional sdhci >> > > Any of these files you need should be added to files.arm64 being > optional on the appropriate soc_ value. I don’t quite follow. These files are shared between ARM and ARM64 port, does that mean they should be in both files.arm64 and files.arm? Or in files.arm64 and files.bcm283x?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D7AD0E83-F39B-4AAF-AACE-2C42A4E68529>