Date: Tue, 01 Aug 2006 19:41:30 -0400 From: David Sledge <dsledge@appriss.com> To: freebsd-java@freebsd.org Subject: Re: Q) eclipse 3.2 (Callisto) Message-ID: <44CFE6AA.40204@appriss.com> In-Reply-To: <20060801222049.GA995@watt.intra.caraldi.com> References: <970c0a6b0607280839qc05e2b8p51118955745b7cda@mail.gmail.com> <20060728155808.GI55747@vision.anyware> <768690DD58883C4FAA0C089A534F94DF2054A8@intexch02.int.appriss.com> <970c0a6b0607312222j54352929i829de592c6d704fa@mail.gmail.com> <20060801075213.GA70025@vision.anyware> <44CF9A25.7030504@appriss.com> <20060801222049.GA995@watt.intra.caraldi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Jean-Baptiste Quenot wrote:
* David Sledge:
Here is the link to the completed shar. Let me know ASAP if you
find any problems. I will submit the port tomorrow morning if no
problems are found. I moved the port from eclipse3.2 to eclipse
as you suggested.
Here are a few comments:
* /usr/local/diablo-jdk1.5.0 is hard-coded in the Makefile, you
may use LOCALBASE for that
I had that coded that when I started the port just to get it
going. I just missed going back to fix it. It is now fixed and the
shar file has been updated on the web server.
* Also, I'm wondering why you set a requirement on JDK 1.5 whereas
Eclipse only requires JDK 1.4 for runtime. And compiling with JDK
1.5 is known not to work, I wonder how you could build it
successfully.
I was actually getting errors compiling with the original
settings. I then realized that the error I was getting was coming from
something that changed with jdk 1.5. Can't remember what exactly it
was with trying to recompile that way. The problem was compiling from
jdk1.5 to a lower version so I bumped it up to jdk1.5.
* You added a pkg-plist file, this is not necessary
I added the pkg_plist because I was getting errors during the
"make deinstall" about removing some of the files in the eclipse
directory an thus leaving the directory behind. By adding the
pkg_plist file that problem was resolved.
* The motif stuff is stripped out, but personnally I don't care
I know.
* There is a small error in idReplacer of
patch-features-rcp-build.xml: on line 32 replace linux with
freebsd.
Missed that one, it is now fixed and the shar file has been
updated on the web server.
* Did you make the mozilla stuff work?
As far as I can tell mozilla stuff is working. I am not defining
"WITHOUT_MOZILLA" and I am seeing no trouble. Let me know if it does
not work for you or I am totally missing something.
Thanks for all your input and comments. This is my first time updating
a port for FreeBSD so I'll take any help I can get to be a better
contributor.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?44CFE6AA.40204>