Date: Wed, 13 Oct 2010 16:24:11 -0700
From: "David O'Brien" <obrien@freebsd.org>
To: Jilles Tjoelker <jilles@stack.nl>
Cc: freebsd-current@freebsd.org
Subject: Re: [PATCH] fix shell bug in ${var%pattern} expansion
Message-ID: <20101013232411.GC17164@dragon.NUXI.org>
In-Reply-To: <20101013214247.GA36354@stack.nl>
References: <20101012021914.GA72371@dragon.NUXI.org> <20101013214247.GA36354@stack.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Oct 13, 2010 at 11:42:48PM +0200, Jilles Tjoelker wrote:
> Style bug:
> > +growstrstackblock(int n) {
> The opening brace should be on its own line.
Indeed. I'm surprised I did that. Thank you for catching it.
> Your test is too fragile: it often fails to detect the bug. Calling like
> sh -c '. expansion/trim4.0'
> gives the correct output even with a buggy sh. I propose something like
> this, or perhaps with an additional string comparison:
I also like this test better.
Thank you for the review.
--
-- David (obrien@FreeBSD.org)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101013232411.GC17164>