Date: Sat, 4 Apr 2009 23:12:14 +0000 (UTC) From: Alan Cox <alc@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sys/arm/include vmparam.h src/sys/i386/include vmparam.h src/sys/vm vm_mmap.c Message-ID: <200904042313.n34NDTNN039993@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
alc 2009-04-04 23:12:14 UTC
FreeBSD src repository
Modified files:
sys/arm/include vmparam.h
sys/i386/include vmparam.h
sys/vm vm_mmap.c
Log:
SVN rev 190705 on 2009-04-04 23:12:14Z by alc
Retire VM_PROT_READ_IS_EXEC. It was intended to be a micro-optimization,
but I see no benefit from it today.
VM_PROT_READ_IS_EXEC was only intended for use on processors that do not
distinguish between read and execute permission. On an mmap(2) or
mprotect(2), it automatically added execute permission if the caller
specified permissions included read permission. The hope was that this
would reduce the number of vm map entries needed to implement an address
space because there would be fewer neighboring vm map entries that differed
only in the presence or absence of VM_PROT_EXECUTE. (See vm/vm_mmap.c
revision 1.56.)
Today, I don't see any real applications that benefit from
VM_PROT_READ_IS_EXEC. In any case, vm map entries are now organized
as a self-adjusting binary search tree instead of an ordered list. So,
the need for coalescing vm map entries is not as great as it once was.
Revision Changes Path
1.14 +0 -2 src/sys/arm/include/vmparam.h
1.49 +0 -4 src/sys/i386/include/vmparam.h
1.229 +0 -12 src/sys/vm/vm_mmap.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200904042313.n34NDTNN039993>