Date: Sat, 3 Jul 1999 10:00:17 +0930 From: Greg Lehey <grog@lemis.com> To: Ben Rosengart <ben@skunk.org> Cc: "Brian F. Feldman" <green@unixhelp.org>, current@FreeBSD.ORG Subject: Re: Fixing other people's code (was: world broken in vinum (PATCH)) Message-ID: <19990703100017.A87392@freebie.lemis.com> In-Reply-To: <Pine.BSF.4.05.9907030008070.27759-100000@penelope.skunk.org>; from Ben Rosengart on Sat, Jul 03, 1999 at 12:09:53AM %2B0000 References: <19990703093223.V87392@freebie.lemis.com> <Pine.BSF.4.05.9907030008070.27759-100000@penelope.skunk.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday, 3 July 1999 at 0:09:53 +0000, Ben Rosengart wrote: > On Sat, 3 Jul 1999, Greg Lehey wrote: > >> I personally think that, in such a case, you'd be justified to commit >> it as a temporary measure. Due to the difference in time zones, this >> has hit people while I've been asleep. That doesn't mean the commit >> would stay, of course, but at least it would save people unnecessary >> pain. Note, of course, that I have now committed the correct file, >> which I had forgotten last night. >> >> What do you others think? > > Was the fix that wasn't yours correct? No. > 'Cause I'd rather have code that doesn't compile than code that > compiles but is subtly wrong. Well, you can now have code that compiles and is correct :-) Seriously, the only problem with Brian's fix was that it added a new variable. It would have made the stats list functions not work. I think that, for the period of time it would have been there, it would have been the right thing to do: most people don't use Vinum, so the breakage there is just a thorn in their side. For those who do, they'll notice the problem and report it. Greg -- See complete headers for address, home page and phone numbers finger grog@lemis.com for PGP public key To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19990703100017.A87392>