Date: Mon, 14 Jul 2014 13:43:58 -0700 From: <dteske@FreeBSD.org> To: <freebsd-rc@freebsd.org> Cc: dteske@freebsd.org, Allan Jude <allanjude@freebsd.org>, 'Michael Dexter' <editor@callfortesting.org> Subject: Bug 191869 - tmux(1) refuses to start via service(8) Message-ID: <017a01cf9fa4$568196e0$0384c4a0$@FreeBSD.org>
next in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] Hi -rc, I'd like to get a review on a proposed patch to service(8). I've filed BUG #191869: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191869 Proposed commit/message below: Fix an issue with service(8) where utilities such as screen(1) and tmux(1) would behave differently when utilizing rc-script was invoked manually vs. service(8). The issue being that these utilities require the TERM environ variable to be set and service(8) was not passing it down. Reported by: Michael Dexter <editor@callfortesting.org> Reviewed by: <your name here> MFC after: 3 days X-MFC-to: stable/10, stable/9 --This line, and those below, will be ignored-- M service/service.sh <see attached patch.txt> [-- Attachment #2 --] Index: usr.sbin/service/service.sh =================================================================== --- usr.sbin/service/service.sh (revision 268628) +++ usr.sbin/service/service.sh (working copy) @@ -139,7 +139,7 @@ cd / for dir in /etc/rc.d $local_startup; do if [ -x "$dir/$script" ]; then [ -n "$VERBOSE" ] && echo "$script is located in $dir" - exec env -i HOME=/ PATH=/sbin:/bin:/usr/sbin:/usr/bin $dir/$script $* + exec env -i HOME=/ PATH=/sbin:/bin:/usr/sbin:/usr/bin TERM="$TERM" $dir/$script $* fi done
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?017a01cf9fa4$568196e0$0384c4a0$>