Date: Tue, 8 May 2001 20:39:20 -0400 (EDT) From: mad1@tapil.com To: FreeBSD-gnats-submit@freebsd.org Subject: bin/27218: fix included -- restore drops files on tape transitions in -N mode Message-ID: <200105090039.f490dKH64314@tapil.com>
next in thread | raw e-mail | index | archive | help
>Number: 27218
>Category: bin
>Synopsis: fix included -- restore drops files on tape transitions in -N mode
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue May 08 17:40:01 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator:
>Release: FreeBSD 4.3-RELEASE i386
>Organization:
>Environment:
System: FreeBSD grumpy.tapil.com 4.3-RELEASE FreeBSD 4.3-RELEASE #0: Tue Apr 24 15:05:58 EDT 2001 madler@grumpy.tapil.com:/usr/obj/usr/src/sys/GRUMPY i386
>Description:
When verifying a multi-tape dump using restore -N, files at the start of
each new tape are incorrectly listed as missing. This is due to a bug
in getvol(). At the end of the routine it returns if curfile.action is
USING. Otherwise, it acts as though the tape is the start of a dump.
When -N is set, curfile.action is always SKIP. I believe that the test
should return and not reinitialize when curfile.action is either USING
or SKIP.
>How-To-Repeat:
Make a multi-tape or multi-file dump set and try "restore -N -r". Note the
reported failure at the start of each tape other than the first.
>Fix:
Patch /usr/src/sbin/restore/tape.c:
*** tape.c Tue May 8 20:23:55 2001
--- tape.c.~1~ Mon Apr 23 12:26:52 2001
***************
*** 439,445 ****
readtape(buf);
}
}
! if (curfile.action == USING || curfile.action == SKIP) {
if (volno == 1)
panic("active file into volume 1\n");
return;
--- 439,445 ----
readtape(buf);
}
}
! if (curfile.action == USING) {
if (volno == 1)
panic("active file into volume 1\n");
return;
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200105090039.f490dKH64314>