Date: Wed, 26 Mar 2008 10:56:04 -0700 (PDT) From: Abdullah Ibn Hamad Al-Marri <wearabnet@yahoo.ca> To: Abdullah Ibn Hamad Al-Marri <wearabnet@yahoo.ca>, John Baldwin <jhb@FreeBSD.org>, src-committers@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/cpufreq est.c Message-ID: <510.33130.qm@web33708.mail.mud.yahoo.com>
next in thread | raw e-mail | index | archive | help
----- Original Message ---- > From: Abdullah Ibn Hamad Al-Marri <wearabnet@yahoo.ca> > To: John Baldwin <jhb@FreeBSD.org>; src-committers@FreeBSD.org; cvs-src@FreeBSD.org > Sent: Friday, March 14, 2008 3:45:01 PM > Subject: Re: cvs commit: src/sys/i386/cpufreq est.c > > ----- Original Message ---- > > From: John Baldwin > > To: src-committers@FreeBSD.org; cvs-src@FreeBSD.org; cvs-all@FreeBSD.org > > Sent: Tuesday, March 11, 2008 1:00:36 AM > > Subject: cvs commit: src/sys/i386/cpufreq est.c > > > > jhb 2008-03-10 22:00:36 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/i386/cpufreq est.c > > Log: > > - Don't execute cpuid to fetch the features. We already have the features > > present in cpu_feature2. Also, use CPUID2_EST rather than a magic > > number. > > - Don't free the ACPI settings list in detach if we are going to fail the > > request. Otherwise an attempt to kldunload est would free the array > > but the driver would keep trying to use it. > > > > MFC after: 1 week > > > > Revision Changes Path > > 1.14 +5 -5 src/sys/i386/cpufreq/est.c > > Hello John > > Could you please MFC it to RELENG_7 now? :) > > > -- > Regards, > > -Abdullah Ibn Hamad Al-Marri > Arab Portal > http://www.WeArab.Net/ John, This is C2Q CPU Q6600. Upgraded today with RELENG_7. FreeBSD 7.0-STABLE #0: Wed Mar 26 20:06:53 AST 2008 arabian@www.ArabPe.Com:/usr/obj/usr/src/sys/ARABPE Timecounter "i8254" frequency 1193182 Hz quality 0 CPU: Intel(R) Core(TM)2 Quad CPU Q6600 @ 2.40GHz (2400.01-MHz K8-class CPU) Origin = "GenuineIntel" Id = 0x6fb Stepping = 11 Features=0xbfebfbff<FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CLFLUSH,DTS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE> Features2=0xe3bd<SSE3,RSVD2,MON,DS_CPL,VMX,EST,TM2,SSSE3,CX16,xTPR,PDCM> AMD Features=0x20100800<SYSCALL,NX,LM> AMD Features2=0x1<LAHF> Cores per package: 4 usable memory = 4277587968 (4079 MB) avail memory = 4116393984 (3925 MB) ACPI APIC Table: <GBT GBTUACPI> FreeBSD/SMP: Multiprocessor System Detected: 4 CPUs cpu0 (BSP): APIC ID: 0 cpu1 (AP): APIC ID: 1 cpu2 (AP): APIC ID: 2 cpu3 (AP): APIC ID: 3 ioapic0: Changing APIC ID to 2 ioapic0 <Version 2.0> irqs 0-23 on motherboard acpi0: <GBT GBTUACPI> on motherboard acpi0: [ITHREAD] acpi0: Power Button (fixed) acpi0: reservation of 0, a0000 (3) failed acpi0: reservation of 100000, cf4e0000 (3) failed Timecounter "ACPI-fast" frequency 3579545 Hz quality 1000 acpi_timer0: <24-bit timer at 3.579545MHz> port 0x408-0x40b on acpi0 acpi_hpet0: <High Precision Event Timer> iomem 0xfed00000-0xfed003ff on acpi0 Timecounter "HPET" frequency 14318180 Hz quality 900 cpu0: <ACPI CPU> on acpi0 acpi_perf0: <ACPI CPU Frequency Control> on cpu0 p4tcc0: <CPU Frequency Thermal Control> on cpu0 cpu1: <ACPI CPU> on acpi0 est1: <Enhanced SpeedStep Frequency Control> on cpu1 est: CPU supports Enhanced Speedstep, but is not recognized. ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ est: cpu_vendor GenuineIntel, msr 91f091f0600091f ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ device_attach: est1 attach returned 6 p4tcc1: <CPU Frequency Thermal Control> on cpu1 cpu2: <ACPI CPU> on acpi0 est2: <Enhanced SpeedStep Frequency Control> on cpu2 est: CPU supports Enhanced Speedstep, but is not recognized. est: cpu_vendor GenuineIntel, msr 91f091f0600091f device_attach: est2 attach returned 6 p4tcc2: <CPU Frequency Thermal Control> on cpu2 cpu3: <ACPI CPU> on acpi0 est3: <Enhanced SpeedStep Frequency Control> on cpu3 est: CPU supports Enhanced Speedstep, but is not recognized. est: cpu_vendor GenuineIntel, msr 91f091f0600091f device_attach: est3 attach returned 6 p4tcc3: <CPU Frequency Thermal Control> on cpu3 acpi_button0: <Power Button> on acpi0 pcib0: <ACPI Host-PCI bridge> port 0xcf8-0xcff on acpi0 pci0: <ACPI PCI bus> on pcib0 vgapci0: <VGA-compatible display> port 0xe000-0xe007 mem 0xf3100000-0xf317ffff,0xe0000000-0xefffffff,0xf3000000-0xf30fffff irq 16 at device 2.0 on pci0 pcib1: <ACPI PCI-PCI bridge> irq 16 at device 28.0 on pci0 pci1: <ACPI PCI bus> on pcib1 pcib2: <ACPI PCI-PCI bridge> irq 16 at device 28.4 on pci0 pci2: <ACPI PCI bus> on pcib2 atapci0: <JMicron JMB368 UDMA133 controller> port 0xc000-0xc007,0xc100-0xc103,0xc200-0xc207,0xc300-0xc303,0xc400-0xc40f irq 16 at device 0.0 on pci2 atapci0: [ITHREAD] ata2: <ATA channel 0> on atapci0 ata2: [ITHREAD] pcib3: <ACPI PCI-PCI bridge> irq 17 at device 28.5 on pci0 pci3: <ACPI PCI bus> on pcib3 re0: <RealTek 8168/8111B PCIe Gigabit Ethernet> port 0xd000-0xd0ff mem 0xf2000000-0xf2000fff irq 17 at device 0.0 on pci3 re0: Using 2 MSI messages miibus0: <MII bus> on re0 rgephy0: <RTL8169S/8110S/8211B media interface> PHY 1 on miibus0 rgephy0: 10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, 1000baseT, 1000baseT-FDX, auto re0: Ethernet address: 00:1a:4d:4f:76:07 re0: [FILTER] re0: [FILTER] pcib4: <ACPI PCI-PCI bridge> at device 30.0 on pci0 pci4: <ACPI PCI bus> on pcib4 isab0: <PCI-ISA bridge> at device 31.0 on pci0 isa0: <ISA bus> on isab0 atapci1: <Intel AHCI controller> port 0xe400-0xe407,0xe500-0xe503,0xe600-0xe607,0xe700-0xe703,0xe800-0xe81f mem 0xf3180000-0xf31807ff irq 19 at device 31.2 on pci0 atapci1: [ITHREAD] atapci1: AHCI Version 01.20 controller with 4 ports detected ata3: <ATA channel 0> on atapci1 ata3: [ITHREAD] ata4: <ATA channel 1> on atapci1 ata4: [ITHREAD] ata5: <ATA channel 2> on atapci1 ata5: port not implemented ata5: [ITHREAD] ata6: <ATA channel 3> on atapci1 ata6: port not implemented ata6: [ITHREAD] ata7: <ATA channel 4> on atapci1 ata7: [ITHREAD] ata8: <ATA channel 5> on atapci1 ata8: [ITHREAD] pci0: <serial bus, SMBus> at device 31.3 (no driver attached) atkbdc0: <Keyboard controller (i8042)> at port 0x60,0x64 on isa0 atkbd0: <AT Keyboard> irq 1 on atkbdc0 kbd0 at atkbd0 atkbd0: [GIANT-LOCKED] atkbd0: [ITHREAD] sc0: <System console> at flags 0x100 on isa0 sc0: VGA <16 virtual consoles, flags=0x300> vga0: <Generic ISA VGA> at port 0x3c0-0x3df iomem 0xa0000-0xbffff on isa0 Timecounters tick every 1.000 msec ipfw2 initialized, divert loadable, nat loadable, rule-based forwarding disabled, default to accept, logging limited to 10000 packets/entry by default ad6: 238475MB <WDC WD2500AAKS-00VSA0 01.01B01> at ata3-master SATA300 ad8: 715404MB <WDC WD7500AAKS-00RBA0 30.04G30> at ata4-master SATA300 SMP: AP CPU #1 Launched! SMP: AP CPU #3 Launched! SMP: AP CPU #2 Launched! Trying to mount root from ufs:/dev/ad6s1a re0: link state changed to UP -- Regards, -Abdullah Ibn Hamad Al-Marri Arab Portal http://www.WeArab.Net/ ____________________________________________________________________________________ Be a better friend, newshound, and know-it-all with Yahoo! Mobile. Try it now. http://mobile.yahoo.com/;_ylt=Ahu06i62sR8HDtDypao8Wcj9tAcJ
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?510.33130.qm>