Date: Thu, 30 May 2024 01:46:46 +0200 From: Daniel Engberg <daniel.engberg.lists@pyret.net> To: Jimmy Olgeni <olgeni@FreeBSD.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 86bff3d95b03 - main - www/xcaddy: add missing RUN_DEPENDS on lang/go. Message-ID: <03644695a67503b33997b92c38435a04@mail.infomaniak.com> In-Reply-To: <202405290824.44T8OILm072213@gitrepo.freebsd.org> References: <202405290824.44T8OILm072213@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--_=_swift_1717026406_e800f9d799b6facc34f83e548c09ca23_=_ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2024-05-29T10:24:18.000+02:00, Jimmy Olgeni <olgeni@FreeBSD.org> wrote= : >=C2=A0The=C2=A0branch=C2=A0main=C2=A0has=C2=A0been=C2=A0updated= =C2=A0by=C2=A0olgeni: >=C2=A0 >=C2=A0URL:=C2=A0https://cgit.FreeBSD.org= /ports/commit/?id=3D86bff3d95b03955a22d181fe064f81db968a1bb6 >=C2=A0 >= =C2=A0commit=C2=A086bff3d95b03955a22d181fe064f81db968a1bb6 >=C2=A0 >= =C2=A0Author:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Jimmy=C2=A0Olgeni=C2=A0<olgeni@F= reeBSD.org> >=C2=A0 >=C2=A0AuthorDate:=C2=A02024-05-29=C2=A008:19:39= =C2=A0+0000 >=C2=A0 >=C2=A0Commit:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Jimmy= =C2=A0Olgeni=C2=A0<olgeni@FreeBSD.org> >=C2=A0 >=C2=A0CommitDate:=C2= =A02024-05-29=C2=A008:23:58=C2=A0+0000 >=C2=A0 >=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0www/xcaddy:=C2=A0add=C2=A0missing=C2=A0RUN_DEPENDS=C2=A0on= =C2=A0lang/go. >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 >=C2=A0 >= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0xcaddy=C2=A0uses=C2=A0go=C2=A0to=C2=A0build= =C2=A0custom=C2=A0releases=C2=A0of=C2=A0caddy,=C2=A0so=C2=A0it=C2=A0actuall= y=C2=A0needs >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0it=C2=A0at=C2=A0run= time. >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 >=C2=A0 >=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0PR:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0279358 >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0Reported=C2=A0by:=C2=A0=C2=A0=C2=A0=C2=A0Robert=C2=A0William=C2= =A0Vesterman=C2=A0<bob@vesterman.com> >=C2=A0 >=C2=A0--- >=C2=A0 >= =C2=A0=C2=A0www/xcaddy/Makefile=C2=A0|=C2=A04=C2=A0++++ >=C2=A0 >=C2= =A0=C2=A01=C2=A0file=C2=A0changed,=C2=A04=C2=A0insertions(+) >=C2=A0 >= =C2=A0diff=C2=A0--git=C2=A0a/www/xcaddy/Makefile=C2=A0b/www/xcaddy/Makefile= >=C2=A0 >=C2=A0index=C2=A0d8dbd019679e..0fc20011a2eb=C2=A0100644 >= =C2=A0 >=C2=A0---=C2=A0a/www/xcaddy/Makefile >=C2=A0 >=C2=A0+++=C2= =A0b/www/xcaddy/Makefile >=C2=A0 >=C2=A0@@=C2=A0-1,6=C2=A0+1,7=C2=A0@@= >=C2=A0 >=C2=A0=C2=A0PORTNAME=3D=C2=A0=C2=A0=C2=A0=C2=A0xcaddy >= =C2=A0 >=C2=A0=C2=A0DISTVERSIONPREFIX=3D=C2=A0=C2=A0=C2=A0=C2=A0v >= =C2=A0 >=C2=A0=C2=A0DISTVERSION=3D=C2=A0=C2=A0=C2=A0=C2=A00.4.1 >=C2= =A0 >=C2=A0+PORTREVISION=3D=C2=A0=C2=A0=C2=A0=C2=A01 >=C2=A0 >=C2= =A0=C2=A0CATEGORIES=3D=C2=A0=C2=A0=C2=A0=C2=A0www >=C2=A0 >=C2=A0=C2= =A0DIST_SUBDIR=3D=C2=A0=C2=A0=C2=A0=C2=A0xcaddy >=C2=A0 >=C2=A0=C2= =A0 >=C2=A0 >=C2=A0@@=C2=A0-11,6=C2=A0+12,9=C2=A0@@=C2=A0WWW=3D=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0https://github.com/caddyserver= /xcaddy >=C2=A0 >=C2=A0=C2=A0LICENSE=3D=C2=A0=C2=A0=C2=A0=C2=A0APACHE20= >=C2=A0 >=C2=A0=C2=A0LICENSE_FILE=3D=C2=A0=C2=A0=C2=A0=C2=A0${WRKSRC}/= LICENSE >=C2=A0 >=C2=A0=C2=A0 >=C2=A0 >=C2=A0+#=C2=A0xcaddy=C2= =A0actually=C2=A0needs=C2=A0to=C2=A0run=C2=A0the=C2=A0go=C2=A0command=C2= =A0to=C2=A0perform=C2=A0builds >=C2=A0 >=C2=A0+RUN_DEPENDS=3D=C2=A0= =C2=A0=C2=A0=C2=A0go:lang/go >=C2=A0 >=C2=A0+ >=C2=A0 >=C2=A0=C2= =A0USES=3D=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0go:modules >= =C2=A0 >=C2=A0=C2=A0 >=C2=A0 >=C2=A0=C2=A0USE_GITHUB=3D=C2=A0=C2= =A0=C2=A0=C2=A0yes Hi, Please use the helper instead of RUN_DEPEN= DS https://cgit.freebsd.org/ports/tree/Mk/Uses/go.mk#n16 Best reg= ards, Daniel --_=_swift_1717026406_e800f9d799b6facc34f83e548c09ca23_=_ Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable <html><body><div>On 2024-05-29T10:24:18.000+02:00, Jimmy Olgeni <olgeni@= FreeBSD.org> wrote:<br></div><div ><div><br></div></div><div><br></div><= div class=3D"ik_mail_quote answerContentMessage"><blockquote class=3D"ws-ng= -quote"><pre style=3D"white-space: normal;"><div>The branch main has been u= pdated by olgeni:<br></div><div><br></div><div>URL: <a data-ik=3D"ik-secure= " rel=3D"noopener noreferrer" class=3D"defaultMailLink" href=3D"https://cgi= t.FreeBSD.org/ports/commit/?id=3D86bff3d95b03955a22d181fe064f81db968a1bb6" = target=3D"_blank">https://cgit.FreeBSD.org/ports/commit/?id=3D86bff3d95b039= 55a22d181fe064f81db968a1bb6</a><br></div><div><br></div><div>commit 86bff3d= 95b03955a22d181fe064f81db968a1bb6<br></div><div>Author: Jimmy Olgeni &l= t;<a class=3D"defaultMailLink" href=3D"mailto:olgeni@FreeBSD.org">olgeni@Fr= eeBSD.org</a>><br></div><div>AuthorDate: 2024-05-29 08:19:39 +0000<br></= div><div>Commit: Jimmy Olgeni <<a class=3D"defaultMailLink" href=3D"= mailto:olgeni@FreeBSD.org">olgeni@FreeBSD.org</a>><br></div><div>CommitD= ate: 2024-05-29 08:23:58 +0000<br></div><div><br></div><div> www/xcaddy:= add missing RUN_DEPENDS on lang/go.<br></div><div> <br></div><div> x= caddy uses go to build custom releases of caddy, so it actually needs<br></= div><div> it at runtime.<br></div><div> <br></div><div> PR: = 279358<br></div><div> Reported by: Robert William Vesterman <= ;<a class=3D"defaultMailLink" href=3D"mailto:bob@vesterman.com">bob@vesterm= an.com</a>><br></div><div>---<br></div><div> www/xcaddy/Makefile | 4 +++= +<br></div><div> 1 file changed, 4 insertions(+)<br></div><div><br></div><d= iv>diff --git a/www/xcaddy/Makefile b/www/xcaddy/Makefile<br></div><div>ind= ex d8dbd019679e..0fc20011a2eb 100644<br></div><div>--- a/www/xcaddy/Makefil= e<br></div><div>+++ b/www/xcaddy/Makefile<br></div><div>@@ -1,6 +1,7 @@<br>= </div><div> PORTNAME=3D=09xcaddy<br></div><div> DISTVERSIONPREFIX=3D=09v<br= ></div><div> DISTVERSION=3D=090.4.1<br></div><div>+PORTREVISION=3D=091<br><= /div><div> CATEGORIES=3D=09www<br></div><div> DIST_SUBDIR=3D=09xcaddy<br></= div><div> <br></div><div>@@ -11,6 +12,9 @@ WWW=3D=09=09<a data-ik=3D"ik-sec= ure" rel=3D"noopener noreferrer" class=3D"defaultMailLink" href=3D"https://= github.com/caddyserver/xcaddy" target=3D"_blank">https://github.com/caddyse= rver/xcaddy</a><br></div><div> LICENSE=3D=09APACHE20<br></div><div> LICENSE= _FILE=3D=09${WRKSRC}/LICENSE<br></div><div> <br></div><div>+# xcaddy actual= ly needs to run the go command to perform builds<br></div><div>+RUN_DEPENDS= =3D=09go:lang/go<br></div><div>+<br></div><div> USES=3D=09=09go:modules<br>= </div><div> <br></div><div> USE_GITHUB=3D=09yes<br></div></pre></blockquote= ></div><div>Hi,<br></div><div><br></div><div>Please use the helper instead = of RUN_DEPENDS<br></div><div><a href=3D"https://cgit.freebsd.org/ports/tree= /Mk/Uses/go.mk#n16" target=3D"_blank" rel=3D"noopener noreferrer" data-ik= =3D"ik-secure">https://cgit.freebsd.org/ports/tree/Mk/Uses/go.mk#n16</a><br= ></div><div><br></div><div>Best regards,<br></div><div>Daniel<br></div></bo= dy></html> --_=_swift_1717026406_e800f9d799b6facc34f83e548c09ca23_=_--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?03644695a67503b33997b92c38435a04>