Date: Mon, 03 Apr 2023 16:39:04 +0200 From: Corvin =?ISO-8859-1?Q?K=F6hne?= <corvink@FreeBSD.org> To: Peter Grehan <grehan@freebsd.org> Cc: virtualization@FreeBSD.org Subject: Re: [PATCH] OvmfPkg/BhyveBhf: install bhyve's ACPI tables Message-ID: <e539403193518c7dd744741410be632947414213.camel@FreeBSD.org> In-Reply-To: <a2e19eb1-bb85-84f6-f805-c8065076bbf0@freebsd.org> References: <20230331123936.540020-1-corvink@FreeBSD.org> <a2e19eb1-bb85-84f6-f805-c8065076bbf0@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-vq6tboqwTN6TRNrDSfEC Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2023-04-03 at 21:26 +1000, Peter Grehan wrote: > Hi Corvin, >=20 > > I would like to send the following patch to the EDKII project. > > Therefore, I'd like to get some feedback from the bhyve community > > before > > sending them to EDKII. >=20 > =C2=A0 Thanks for giving a heads-up. >=20 > =C2=A0 The patch looks fine to me. The only minor suggestion I have is to > use=20 > the qemu fwcfg interface to locate the RSDP instead of searching > through=20 > memory, since presumably any new ACPI table functionality in bhyve > would=20 > be after this point in time where qemu fwcfg is already supported. >=20 > later, >=20 > Peter. Hi Peter, thanks for your reply. Using the qemu fwcfg has one big disadvantage: Bhyve's fwctl and qemu's fwcfg can't be used at the same time. Due to backward compatibility reasons, bhyve uses fwctl as default. So, using qemu's fwcfg to locate the rsdp only works, if the user changes his bhyve call. I don't want to use fwctl to locate the rsdp because IMHO we should migrate to fwcfg. So, we shouldn't add new features to fwctl. Btw: I'm also preparing some patches to support qemu's acpi table loader. So, if we like to use qemu's fwcfg, we should use the loader instead of an own baked solution. --=20 Kind regards, Corvin --=-vq6tboqwTN6TRNrDSfEC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgvRSla3m2t/H2U9G2FTaVjFeAmoFAmQq5QgACgkQ2FTaVjFe Amo5+Q//eWW3Bh9hrfSpbtZ1y7fj61sFgQ1MsYxpLvof/73KXwWDvm0xG47fIBrG 5wLzFE5eLPkUHvXWvpz8H0HrHKKo3fBfmL31YHuhoTZz1cE1N6TzH3U4CQrqs7Bd 7LnGah11CGazIFRKkJJEaml3HzjUH2K9YOwQedj4rrmXCN61Ps1m8sAquptcpr1Z m7pdJJl+2ADAuYUkp47sQi/eF65CG1Vae6xhaqB3VjmgPuzsgXQAgwRjUQ6dOtMg 7Lmg+x3yIbl2riKNSzxVlIgfrCas/y4R/NkLYihhebZf0jDFYhd1z3yY2Hdb/znn 4fJluv6vHd2qb8Vw2hBbmQSznD9P5qtNN8UmFLKyPDho+vNMhJJLICgkmdHkaUJT 67tId1ax9ZOMsmkrS4sK3AUD3Y1SFaKS13qZeSrjzuTI5JQHRZRyyvA6IDtbAloH 0bT/el35iEovReyJ5UGE5Yvxcf8kSmKkqcU8RNtTFerXwT0LSgxzLmbQ05aX8TKJ r65JqbA7gNP5OAZ/OaP+pdfU1yaSnrurI94lgOX4KS2WAM4qsRzpu4Y8zjQGa6aA tFeDQSJUCbbBOrphcvCWJIEHz/EHjxDfy0g8vN4IjWejIeDgRiczxU5Vu+fa/uIi AgE+33iEAx+LiMe5GNxOC3nI8B90WEwWHWx7oSETHZf5fhNoF+c= =3BV7 -----END PGP SIGNATURE----- --=-vq6tboqwTN6TRNrDSfEC--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?e539403193518c7dd744741410be632947414213.camel>