Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 4 Jan 2010 20:00:24 +0100
From:      Luigi Rizzo <rizzo@iet.unipi.it>
To:        Michael Tuexen <tuexen@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   moving sctp to a separate directory ? (Re: svn commit: r201523 - head/sys/netinet)
Message-ID:  <20100104190024.GA47532@onelab2.iet.unipi.it>
In-Reply-To: <201001041825.o04IPcXb043347@svn.freebsd.org>
References:  <201001041825.o04IPcXb043347@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
taking a random commit to this tree -- would you guys consider moving
the sctp sources to its own directory, e.g. netinet/sctp/ or something
that suits better ?

It would help to browse through the directory:

	NAME		FILES		LINES

	netinet/	156		153k
	sctp*		 36		 66k
	tcp*		 24		 16k
	ipfw/		  9		  9k


I understand that some of the headers should remain in netinet/
but surely the code is not bound to a specific place...

cheers
luigi

On Mon, Jan 04, 2010 at 06:25:38PM +0000, Michael Tuexen wrote:
> Author: tuexen
> Date: Mon Jan  4 18:25:38 2010
> New Revision: 201523
> URL: http://svn.freebsd.org/changeset/base/201523
> 
> Log:
>   Correct usage of parenthesis.
>   
>   PR:	kern/142066
>   Approved by: rrs (mentor)
>   Obtained from: Henning Petersen, Bruce Cran.
>   MFC after: 2 weeks
> 
> Modified:
>   head/sys/netinet/sctp_pcb.c
> 
> Modified: head/sys/netinet/sctp_pcb.c
> ==============================================================================
> --- head/sys/netinet/sctp_pcb.c	Mon Jan  4 18:21:27 2010	(r201522)
> +++ head/sys/netinet/sctp_pcb.c	Mon Jan  4 18:25:38 2010	(r201523)
> @@ -5528,7 +5528,7 @@ sctp_pcb_init()
>  
>  	/* Init the TIMEWAIT list */
>  	for (i = 0; i < SCTP_STACK_VTAG_HASH_SIZE; i++) {
> -		LIST_INIT(&SCTP_BASE_INFO(vtag_timewait[i]));
> +		LIST_INIT(&SCTP_BASE_INFO(vtag_timewait)[i]);
>  	}
>  
>  #if defined(SCTP_USE_THREAD_BASED_ITERATOR)
> @@ -6385,7 +6385,7 @@ sctp_is_vtag_good(struct sctp_inpcb *inp
>  	}
>  skip_vtag_check:
>  
> -	chain = &SCTP_BASE_INFO(vtag_timewait[(tag % SCTP_STACK_VTAG_HASH_SIZE))];
> +	chain = &SCTP_BASE_INFO(vtag_timewait)[(tag % SCTP_STACK_VTAG_HASH_SIZE)];
>  	/* Now what about timed wait ? */
>  	if (!LIST_EMPTY(chain)) {
>  		/*



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100104190024.GA47532>