Date: Wed, 6 Dec 2017 16:14:59 -0800 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Hans Petter Selasky <hps@selasky.org>, src-committers@freebsd.org, svn-src-projects@freebsd.org Subject: Re: svn commit: r325894 - projects/bsd_rdma_4_9 Message-ID: <a10e6607-bfcd-95d9-03dd-3d1111a2e80d@FreeBSD.org> In-Reply-To: <3436ea01-e8b9-b04d-ecc6-352da5dff215@selasky.org> References: <201711161513.vAGFDThx060235@repo.freebsd.org> <a46a9d84-eb10-0fcf-9312-983dad229a4c@FreeBSD.org> <97fb917d-8495-6ccf-9772-6b05da10e5f1@selasky.org> <b95ef558-751e-af4f-3b28-ea71202bf784@FreeBSD.org> <3436ea01-e8b9-b04d-ecc6-352da5dff215@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vA2JWGWfbQxH5pTmaFIinEX0xS5V9B2sn Content-Type: multipart/mixed; boundary="4lqkcn6XH7co2I8VAGV6xWAkIQEUGgDmJ"; protected-headers="v1" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Hans Petter Selasky <hps@selasky.org>, src-committers@freebsd.org, svn-src-projects@freebsd.org Message-ID: <a10e6607-bfcd-95d9-03dd-3d1111a2e80d@FreeBSD.org> Subject: Re: svn commit: r325894 - projects/bsd_rdma_4_9 References: <201711161513.vAGFDThx060235@repo.freebsd.org> <a46a9d84-eb10-0fcf-9312-983dad229a4c@FreeBSD.org> <97fb917d-8495-6ccf-9772-6b05da10e5f1@selasky.org> <b95ef558-751e-af4f-3b28-ea71202bf784@FreeBSD.org> <3436ea01-e8b9-b04d-ecc6-352da5dff215@selasky.org> In-Reply-To: <3436ea01-e8b9-b04d-ecc6-352da5dff215@selasky.org> --4lqkcn6XH7co2I8VAGV6xWAkIQEUGgDmJ Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 11/24/2017 5:23 AM, Hans Petter Selasky wrote: > On 11/17/17 00:47, Bryan Drewery wrote: >> On 11/16/2017 1:12 PM, Hans Petter Selasky wrote: >>> On 11/16/17 17:56, Bryan Drewery wrote: >>>> On 11/16/2017 7:13 AM, Hans Petter Selasky wrote: >>>>> Author: hselasky >>>>> Date: Thu Nov 16 15:13:28 2017 >>>>> New Revision: 325894 >>>>> URL: https://svnweb.freebsd.org/changeset/base/325894 >>>>> >>>>> Log: >>>>> =C2=A0=C2=A0=C2=A0 Update list of hardcoded OFED build order depend= encies for >>>>> =C2=A0=C2=A0=C2=A0 the buildworld target. >>>>> =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0 Sponsored by:=C2=A0=C2=A0=C2=A0 Mel= lanox Technologies >>>>> >>>>> Modified: >>>>> =C2=A0=C2=A0=C2=A0 projects/bsd_rdma_4_9/Makefile.inc1 >>>>> >>> >>> Hi, >>> >>>>> >>>> >>>> This isn't right, you don't need to include any 'include' >>>> directories in >>>> here as 'make includes' is ran before 'make libraries'. >>> >>> I tried leaving the include directory out and it failed. >> >> 1. >> I don't see any reason for that.=C2=A0 You shouldn't need >> contrib/ofed/include__L anywhere nor contrib/ofed/include in _ofed_lib= >> list. >> I see contrib/ofed/include hooked up fine for 'make _includes' so long= >> as WITH_OFED is defined. >> >> What was the error? >> >> >> 2. >> Unrelated but I don't like the new directory structure of >> contrib/ofed/usr.bin/* -> contrib/ofed/*.=C2=A0 Now we have contribute= d >> sources in with our FreeBSD Makefiles. >> >> It also makes it more complex in the _ofed_lib list since before we >> could just have contrib/ofed/usr.lib but now must list out every libra= ry. >> >> 3. >> contrib/ofed/Makefile is also super complex now.=C2=A0 It should reall= y just >> look like the Makefile.inc1 changes (minus the include and libthr >> directories).=C2=A0 Just add a .WAIT after include in SUBDIR and make = it >> first. >> You have this chained dependency thing but dependencies are already >> inherited just fine. >> SUBDIR_DEPEND_foo=3D bar >> SUBDIR_DEPEND_baz=3D foo >> >> baz will implicitly depend on bar being built, there's no need to >> explicitly add bar as a dependency but it's not wrong to do so if it h= as >> a LIBADD on it. >> >=20 > See: > https://svnweb.freebsd.org/changeset/base/326146 It's totally wrong and ignores my advice. I'd really just like the whole merge reverted because now I have to go rewrite your rewrite back to what was proper. --=20 Regards, Bryan Drewery --4lqkcn6XH7co2I8VAGV6xWAkIQEUGgDmJ-- --vA2JWGWfbQxH5pTmaFIinEX0xS5V9B2sn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJaKIgDAAoJEDXXcbtuRpfPUxsIAIdlQyaoE6eYZLUc1jSeUMd6 qS4XJa+PswNArYN8yTPGQpxUxZT2UTKLV2qdMV/OFuJytcUX8yEbaPbT60EPSqeQ htKY5/Gxc9kPM3zbfwNIqqiN/0Z6/TDx1aAJNFxukzBYNmB1wAhSf6eBFQM8+jbP qMPcGwg97GAyRhP9Co+t9EjXOSkYXzqTl/1olT6HWHHQNpifjwTW0vPMTojFre9Y G4MPulLm5JDXS85QeRVIdQvgVez42b9fZdmL93BRKi6JKb2G4o7Lg3JOvpD6Nc70 kD2G7UCzpKrICWUgUBpybN+rJW2Dlw6gKf3yOFU8WpCxgHNayCcpzjJITMz5vMc= =YudM -----END PGP SIGNATURE----- --vA2JWGWfbQxH5pTmaFIinEX0xS5V9B2sn--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a10e6607-bfcd-95d9-03dd-3d1111a2e80d>