Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 8 Jan 2015 09:36:16 -0700
From:      Warner Losh <imp@bsdimp.com>
To:        =?utf-8?Q?Micha=C5=82_Stanek?= <mst@semihalf.com>
Cc:        freebsd-current@freebsd.org, freebsd-embedded@freebsd.org
Subject:   Re: [PATCH] Add support for 64-bit AHCI BAR.
Message-ID:  <83015CF1-7D55-4881-8CE9-BC42645A3763@bsdimp.com>
In-Reply-To: <CAMiGqYhKn49LrdFGS4DeGSHDOuVO1Ab0mwubyqGXzxFLmNGoEQ@mail.gmail.com>
References:  <CAMiGqYhKn49LrdFGS4DeGSHDOuVO1Ab0mwubyqGXzxFLmNGoEQ@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help

[-- Attachment #1 --]

> On Jan 8, 2015, at 9:09 AM, Michał Stanek <mst@semihalf.com> wrote:
> 
> <ahci_64bit_bar.patch>

This looks good to my eyes… Given the ordering of the words in the BAR,
you won’t get false positives. It uses the PCI bus code to make the
determination, which eliminates duplication of code in drivers… I like it.

Warner


[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org

iQIcBAEBCgAGBQJUrrIBAAoJEGwc0Sh9sBEA+DsQAJed3kQ+uiKDmKRgrKFGkhj+
HqvyJLds5YxM5vMKuhu/k9i8fKBwB/utLV9aYBfERs8UvWihLzpZe0Y72WCgDjZI
U5cO7l3Sxww15xF4ohFXSTF9yjZl2OnwjwA/yszDICqCoDh6LZ/8KRKWWrc52hjb
tl4kbCkGBtdwZgRDWdtvmi/qn4tGy1xfk7Vd6VqI//4G2eol0qM8cgMEIfqeRMsO
aRlmutOktXnpQfj49zah0xi0bgvrD49B8ED6eL8hDuufNSwL8M1rBdV18mirq24a
5JllROD0SefN0nHJ7IKd+ZfWbMm6xZQEucvNhHfFhQ9jaqUruKDiYCcbP7io/2GW
Z7b3546iInSEatuv6pdijz3aq08mcr00sZuQLxsysl0Vx12udDs9TV/8RTDs7iRW
ROM0GpBQ/S5Lsv82hOdXxpfHjxbXRQUdeqkIJt1C9dNNEthKreYQdIIAWQb15nmE
WdAiT/xvRaYg5PNIj2x3Swczq347HdIdVYo9rcdvtZeBIjHQO0pus+xusvpxD1eC
MawNUTNFKfQAynGNp+NEnAC19CXCs4s1YRzAysf1FZpF4Gc6Il0un2wpN3y+HVPg
nG3FwXlZy47udyB8c4/NT5Vo9S5uN8D36Grid17/Wj08mWyYGTZe//pFi77lyVp8
gUaNTnOeIGJ+JSnj4lrW
=9pWr
-----END PGP SIGNATURE-----

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?83015CF1-7D55-4881-8CE9-BC42645A3763>