Date: Sat, 4 Mar 2017 12:42:56 -0800 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: rgrimes@FreeBSD.org Cc: Bryan Drewery <bdrewery@FreeBSD.org>, Ngie Cooper <ngie@FreeBSD.org>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r314654 - in head/cddl: lib/drti lib/libavl lib/libctf lib/libdtrace lib/libnvpair lib/libumem lib/libuutil lib/libzfs lib/libzfs_core lib/libzpool sbin/zfs sbin/zpool usr.bin/ctfconver... Message-ID: <03156186-221F-4EEB-A86E-077E46E28296@gmail.com> In-Reply-To: <201703042039.v24KdcDE078734@pdx.rh.CN85.dnsmgr.net> References: <201703042039.v24KdcDE078734@pdx.rh.CN85.dnsmgr.net>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] > On Mar 4, 2017, at 12:39, Rodney W. Grimes <freebsd@pdx.rh.CN85.dnsmgr.net> wrote: > > -- Start of PGP signed section. > [ Charset windows-1252 unsupported, converting... ] >> On 3/4/2017 7:20 AM, Rodney W. Grimes wrote: >>> [ Charset UTF-8 unsupported, converting... ] >>>> Author: ngie >>>> Date: Sat Mar 4 11:30:04 2017 >>>> New Revision: 314654 >>>> URL: https://svnweb.freebsd.org/changeset/base/314654 >>>> >>>> Log: >>>> cddl: normalize paths using SRCTOP-relative paths or :H when possible >>>> >>>> This simplifies make logic/output >>>> >>>> While here, remove bogus CFLAGS which look for headers in cddl/lib/libumem. >>>> There aren't any source files there (just Makefiles) >>> Please again, dont intermingle other chnages when doing a tree wide sweep. >>> >>> IMHO if you write While here, you probably should do that thing in a >>> seperate commit, unless this is a single thing your touching in a single >>> commit. >>> >>> It is much easier to glue 2 commits togeather than seperate 1 that >>> changes 2 things. >>> >> >> Agreed. There were also various comment changes in here. This is why >> git is nice, you can git add -p and stage multiple commits before >> pushing. git-svn handles this fine. >> >>> >>> It is also still not clear to me that this was adeqautly disccussed as I >>> only saw 2 +'s for staying relative and no one +ing to move forward with this. >> >> Where is this discussion? The only one I can find is >> https://reviews.freebsd.org/D9207 which seems to have a consensus of >> moving to SRCTOP and :H vs '../..'. > > There was a short discussion here on the commiters list with some others > expressing the prefered the relative status of things even though it > clutters logs. > > D9207 touches 15 files.. I would not consider that an adaquate review that > is actually going to change near every Makefile in the tree, and change what > people have been looking and at working with for 30 years. > > I dont think any differntial that only had 3 or 4 people involed that > is going to effect all developers is adaquate either. Tree wide sweeping > changes should be discussed far more widely. > > Idk, maybe I am to personally attached to the relative paths.. cause I > had a major part in helping them all to work, or perhaps its my been > burned by absolute paths that had to be reworked too many times in > my past. But my gutt is telling me this change is Bad(tm). I care about this for the reasons brewery posted, but I also care because it slows down my terminal output and it bloats my disk with typescript logs that contain unnecessary information. I agree, the :H .CURDIR bits that could have been done with SRCTOP were potentially careless -- I was trying to keep things local to components in the src tree. I’ll go back and fix them if enough people come at me with pitchforks :(. -Ngie [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYuybQAAoJEPWDqSZpMIYVjs4QALh+l5qR5l8p5cBiLrebYtjb UEm2M+f3AWuyeSZXHl4SpB6v9IipgfQRM1yo3je5QwiSHA/hm6vynW/vHObpS0vc ijNnt+kvRa4k2+mzDNjdg5QO/dIIl8bKqq0ZUqw9XlKm/aVx92XpIOp8iocXxShC 8a4TMMB9Y4eRcDZ2j3McZ5sWKSzmChbHrKE8X8KSXXdZUIpNJtwULzGgFlymfLsl USKL2lrRTrEK3LIjU5D10NsUuDIGeaY2B1zScKSZt0sACue43FKQfIeZaaHvMP50 Bt5OkARxu0PvWdK3fcMD5WrgO2QLh/2Y0Wl+RRM5MzZ9FiZaXWvDJ7lr6mqPMQtN cyYIbhIOGawTGUHUfUCswVYENVgvCPaF4T4qvtEelKiHHbm6ueyaVn3vDTByU3Zc O3Yrtz9WpNBspQ9NVg1vUuXdP/TnZbGk+rdLV/RjySfBDrqbUqBMofwQcyPEbCyq NvOTLtn96D4eMDOLsTse6dK1ZJ9c3ogA60fENPHQzSIVl//vGqeyg4nZ5g4H9gT7 7MvBt2yys51CuTnFrdhso1aqMeTbHM9XtnnTivT4GUUdv6xwRR1BEZhIMQWQDWZh iAUhORRkyymd9Afzap+Nq1ZzXO4oxrj1bFCDtopW7gu4b1R4DTPvNeppkODRxsmE C8h9y0wp4O3tdawIE/Hl =gYq8 -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?03156186-221F-4EEB-A86E-077E46E28296>