Date: Mon, 16 Jul 2007 11:36:24 -0700 From: Doug Barton <dougb@FreeBSD.org> To: Rong-En Fan <rafan@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/databases/pgcluster Makefile pkg-plist ports/databases/pgcluster/files patch-configure.in pgcluster.in pgcluster.sh.tmpl pglb.in pglb.sh.tmpl pgreplicate.in pgreplicate.sh.tmpl Message-ID: <469BBAA8.80802@FreeBSD.org> In-Reply-To: <200707161053.l6GArmei061828@repoman.freebsd.org> References: <200707161053.l6GArmei061828@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Rong-En Fan wrote: > rafan 2007-07-16 10:53:48 UTC > > FreeBSD ports repository > > Modified files: > databases/pgcluster Makefile pkg-plist > Added files: > databases/pgcluster/files patch-configure.in pgcluster.in > pglb.in pgreplicate.in > Removed files: > databases/pgcluster/files pgcluster.sh.tmpl pglb.sh.tmpl > pgreplicate.sh.tmpl > Log: > - Patch configure.in so it accepts --infodir option [1] > - While I'm here, use USE_RC_SUBR facility for rc scripts This is always welcome of course, but there are some small oddities with the rc.d scripts. You might want to take a look at http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html, especially the bit about how to do the default variable assignments. It would be better to follow the order that's in the example script on that page, for a variety of reasons that I can elaborate if you wish. Doug > Revision Changes Path > 1.16 +6 -12 ports/databases/pgcluster/Makefile > 1.1 +26 -0 ports/databases/pgcluster/files/patch-configure.in (new) > 1.1 +56 -0 ports/databases/pgcluster/files/pgcluster.in (new) > 1.5 +0 -56 ports/databases/pgcluster/files/pgcluster.sh.tmpl (dead) > 1.1 +34 -0 ports/databases/pgcluster/files/pglb.in (new) > 1.5 +0 -34 ports/databases/pgcluster/files/pglb.sh.tmpl (dead) > 1.1 +36 -0 ports/databases/pgcluster/files/pgreplicate.in (new) > 1.5 +0 -36 ports/databases/pgcluster/files/pgreplicate.sh.tmpl (dead) > 1.3 +0 -3 ports/databases/pgcluster/pkg-plist > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/pgcluster/Makefile.diff?&r1=1.15&r2=1.16&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/pgcluster/files/patch-configure.in > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/pgcluster/files/pgcluster.in > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/pgcluster/files/pgcluster.sh.tmpl > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/pgcluster/files/pglb.in > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/pgcluster/files/pglb.sh.tmpl > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/pgcluster/files/pgreplicate.in > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/pgcluster/files/pgreplicate.sh.tmpl > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/pgcluster/pkg-plist.diff?&r1=1.2&r2=1.3&f=h > -- This .signature sanitized for your protection
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?469BBAA8.80802>